bump tree-sitter-sql - #8464
Conversation
There was a problem hiding this comment.
Would you prefer me to make the diff easier by moving things around in the file to make the keywords align with the current highlights file, or would it be nicer to keep the order of upstream so that future changes upstream are easier to follow?
There was a problem hiding this comment.
I think it would be nicer to follow the upstream highlights closely so that when they make changes to the highlights upstream it's clear where to make changes when we update the grammar. But I don't look at SQL much so I'm not sure if the queries we have in master are significantly better than the new ones in the repo (- looks like they were added since the last time we updated). If you think the new ones look good then let's use those (with the adjustments to the Helix capture names)
| (binary_expression | ||
| operator: _ @operator) | ||
| ((literal) @constant.numeric.integer | ||
| (#lua-match? @constant.numeric.integer "^%d+$")) |
There was a problem hiding this comment.
| (#lua-match? @constant.numeric.integer "^%d+$")) | |
| (#match? @constant.numeric.integer "^\d+$")) |
#lua-match? is nvim-specific. We use just the ones tree-sitter provides in the rust bindings https://tree-sitter.github.io/tree-sitter/using-parsers#predicates (though there are some there like #any-of? that we don't implement yet because we're waiting on a tree-sitter release that adds them)
There was a problem hiding this comment.
Also resolved. Thanks for your patience, I'm new to this tree-sitter world so don't know many of the keywords/possibilities yet, but it looks interesting
| (unary_expression | ||
| operator: _ @operator) | ||
| ((literal) @constant.numeric.float | ||
| (#lua-match? @constant.numeric.float "^[-]?%d*\.%d*$")) |
There was a problem hiding this comment.
Same here - I think the regex from the old highlights should work in place of this one (I think the %d is lua-regex-specific)
* bump tree-sitter-sql * update highlights classes to helix flavour * replace lua-match with match
* bump tree-sitter-sql * update highlights classes to helix flavour * replace lua-match with match
* bump tree-sitter-sql * update highlights classes to helix flavour * replace lua-match with match
* bump tree-sitter-sql * update highlights classes to helix flavour * replace lua-match with match
Bumps to DerekStride/tree-sitter-sql@eeab724 (the commit with the compiled grammar corresponding to
maincommit DerekStride/tree-sitter-sql@385aff4)Changes since previous revision (DerekStride/tree-sitter-sql@7cbac04, 19 June):
group_concatand_aggregate_functiontoinvocationDerekStride/tree-sitter-sql#163filtertoaggregate_functionsDerekStride/tree-sitter-sql#168merge intoupsert statements DerekStride/tree-sitter-sql#182explain,truncateandalter/drop/create schemaDerekStride/tree-sitter-sql#187generated alwaysstatement DerekStride/tree-sitter-sql#194Also see: #7387