Add explain, truncate and alter/drop/create schema - #187
Merged
matthias-Q merged 2 commits intoJul 31, 2023
Merged
Conversation
dmfay
requested changes
Jul 30, 2023
| $.identifier, | ||
| ), | ||
| ), | ||
| repeat($._create_statement), |
Collaborator
There was a problem hiding this comment.
structuring this form into program (now a choice) and deleting the repeat line seems to work well. It does require precedence over _create_statement -> create_schema but I think that's reasonable
prec(2, seq(
$.create_schema,
repeat($._create_statement),
)),
Collaborator
Author
There was a problem hiding this comment.
Not sure that I understand this correctly. Isn't the program node a bit too close to the root of the tree?
I have put it in the create_statement with a left prec.
dmfay
approved these changes
Jul 30, 2023
dmfay
left a comment
dmfay
left a comment
Collaborator
There was a problem hiding this comment.
Not sure that I understand this correctly. Isn't the
programnode a bit too close to the root of the tree?I have put it in the
create_statementwith a left prec.
oh that's a good place for it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds multiple missing statements
I have left out the optional options for explain. They add multiple pg specific keywords. Not sure how we want to handle this. Also, statements that can be analyzed are a mixture of some of the
_dml_read,_dml_writeand_ddl_statement. It is more permissive now, but it also required this precedence. Unfortunately, this significantly increases compilation time and parser size again.CREATE SCHEMAallows to be followed by other CREATE statements. Again, it is now permissive and requires a precedence.