feat: adds merge into upsert statements - #182
Merged
Merged
Conversation
matthias-Q
force-pushed
the
merge_into_statement
branch
from
July 14, 2023 06:03
732efb4 to
10aa8c0
Compare
matthias-Q
force-pushed
the
merge_into_statement
branch
from
July 14, 2023 06:04
10aa8c0 to
61760bb
Compare
dmfay
approved these changes
Jul 14, 2023
dmfay
left a comment
dmfay
left a comment
Collaborator
There was a problem hiding this comment.
couple little bookkeeping issues but lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the
MERGE INTOstatement used by Trino/Athena/Snowflake/IcebergReference:
https://trino.io/docs/current/sql/merge.html
https://docs.snowflake.com/en/sql-reference/sql/merge
https://docs.aws.amazon.com/athena/latest/ug/merge-into-statement.html
Note:
I also added the "keyword_check" bash script to the test command, so that we check it during development and not just during CI
I think T-SQL and Oracle also support this statement. On a quick glance, Oracle should be covered, T-SQL has some extra commands.
[Update]: I just realized that Postgres also supports this 😲 It also is almost fully covered! https://www.postgresql.org/docs/current/sql-merge.html