feat: tsql multiple add columns in alter statement - #175
Merged
Conversation
DerekStride
approved these changes
Jul 4, 2023
dmfay
approved these changes
Jul 4, 2023
dmfay
left a comment
dmfay
left a comment
Collaborator
There was a problem hiding this comment.
it's a venial kludge at worst imo but a TODO comment above add_column might be a good idea in case we wind up revisiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #135 and supersedes #144
I feel this is a bit hacky, but I just made the
addkeyword optional, so that it will not repeated in_alter_specificationsI also removed that
renamepart of the test, since this is not valid SQL syntax and made the keywordconstrainoptional. See discussion in #144