Skip to content

CCM-12858 notify send message#154

Merged
nhsd-angel-pastor merged 3 commits intomainfrom
feature/CCM-12858_notify_send_message
Jan 21, 2026
Merged

CCM-12858 notify send message#154
nhsd-angel-pastor merged 3 commits intomainfrom
feature/CCM-12858_notify_send_message

Conversation

@nhsd-angel-pastor
Copy link
Copy Markdown
Contributor

@nhsd-angel-pastor nhsd-angel-pastor commented Dec 16, 2025 •
edited
Loading

Description

New core notifier lambda that handles PMDResourceAvailable. See test evidences in https://nhsd-jira.digital.nhs.uk/browse/CCM-12858?focusedId=2667914&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-2667914

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-12858_notify_send_message branch from f44da6c to 61eb084 Compare December 16, 2025 14:11
@Ian-Hodges Ian-Hodges changed the title Feature/ccm 12858 notify send message CCM-12858 notify send message Dec 17, 2025
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-12858_notify_send_message branch 12 times, most recently from d03575d to fa7e2bc Compare December 19, 2025 14:32
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-12858_notify_send_message branch 14 times, most recently from b5b9cb2 to 968536e Compare January 14, 2026 11:39
@nhsd-angel-pastor nhsd-angel-pastor marked this pull request as ready for review January 14, 2026 13:42
@nhsd-angel-pastor nhsd-angel-pastor requested a review from a team as a code owner January 14, 2026 13:42
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-12858_notify_send_message branch 2 times, most recently from bbe3bc8 to 7737709 Compare January 15, 2026 09:09
Ian-Hodges
Ian-Hodges reviewed Jan 15, 2026
View reviewed changes
Comment thread lambdas/core-notifier-lambda/src/apis/sqs-handler.ts Outdated
Ian-Hodges
Ian-Hodges reviewed Jan 15, 2026
View reviewed changes
Comment thread lambdas/core-notifier-lambda/src/app/notify-api-client.ts Outdated
Ian-Hodges
Ian-Hodges reviewed Jan 15, 2026
View reviewed changes
Comment thread lambdas/core-notifier-lambda/src/app/notify-api-client.ts Outdated
Ian-Hodges
Ian-Hodges reviewed Jan 15, 2026
View reviewed changes
Comment thread lambdas/core-notifier-lambda/src/domain/request-notify-error.ts Outdated
Ian-Hodges
Ian-Hodges reviewed Jan 15, 2026
View reviewed changes
Comment thread tests/playwright/digital-letters-component-tests/core-notify.component.spec.ts Outdated
Ian-Hodges
Ian-Hodges previously approved these changes Jan 15, 2026
View reviewed changes
@Ian-Hodges Ian-Hodges self-assigned this Jan 16, 2026
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-12858_notify_send_message branch from c8c1275 to 6e7e259 Compare January 16, 2026 10:49
sidnhs
sidnhs reviewed Jan 16, 2026
View reviewed changes
Comment thread infrastructure/terraform/components/dl/module_sqs_core_notifier.tf Outdated
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-12858_notify_send_message branch 3 times, most recently from 1b56f07 to 352bd02 Compare January 16, 2026 14:23
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-12858_notify_send_message branch from 352bd02 to 015cafe Compare January 16, 2026 14:33
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-12858_notify_send_message branch from 015cafe to fab6b89 Compare January 16, 2026 16:22
@nhsd-angel-pastor nhsd-angel-pastor merged commit 7f9e6b7 into main Jan 21, 2026
37 checks passed
@nhsd-angel-pastor nhsd-angel-pastor deleted the feature/CCM-12858_notify_send_message branch January 21, 2026 11:36
@nhsd-angel-pastor nhsd-angel-pastor mentioned this pull request Jan 21, 2026
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ian-Hodges Ian-Hodges Ian-Hodges approved these changes

@sidnhs sidnhs sidnhs approved these changes

@gareth-allan gareth-allan Awaiting requested review from gareth-allan

Assignees

@Ian-Hodges Ian-Hodges

@gareth-allan gareth-allan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nhsd-angel-pastor @Ian-Hodges @sidnhs @gareth-allan