CCM-12858: move senders setup to common file

Author: nhsd-angel-pastor

tests/playwright/config/component/senders.setup.ts

@@ -2,14 +2,36 @@ import { test as setup } from '@playwright/test';
 import senderRepository from 'helpers/sender-helpers';
 import { Sender } from 'utils';
 
+export const SENDER_ID_VALID_FOR_NOTIFY_SANDBOX =
+  'componentTestSender_RoutingConfig';
+export const SENDER_ID_THAT_TRIGGERS_ERROR_IN_NOTIFY_SANDBOX =
+  'componentTestSender_RoutingConfigInvalid';
+export const SENDER_ID_SKIPS_NOTIFY = 'test-sender-1';
+
 const testSenders: Sender[] = [
   {
-    senderId: 'test-sender-1',
+    senderId: SENDER_ID_SKIPS_NOTIFY,
     senderName: 'Test Sender 1',
     meshMailboxSenderId: 'test-mesh-sender-1',
     meshMailboxReportsId: 'test-mesh-reports-1',
     fallbackWaitTimeSeconds: 24 * 3600,
   },
+  {
+    senderId: SENDER_ID_VALID_FOR_NOTIFY_SANDBOX,
+    senderName: 'componentTestSender_RoutingConfig',
+    meshMailboxSenderId: 'meshMailboxSender1',
+    meshMailboxReportsId: 'meshMailboxReports1',
+    routingConfigId: 'b838b13c-f98c-4def-93f0-515d4e4f4ee1',
+    fallbackWaitTimeSeconds: 100,
+  },
+  {
+    senderId: SENDER_ID_THAT_TRIGGERS_ERROR_IN_NOTIFY_SANDBOX,
+    senderName: 'componentTestSender_RoutingConfig',
+    meshMailboxSenderId: 'meshMailboxSender2',
+    meshMailboxReportsId: 'meshMailboxReports2',
+    routingConfigId: 'invalid',
+    fallbackWaitTimeSeconds: 100,
+  },
 ];
 
 setup('Create senders', async () => {

tests/playwright/digital-letters-component-tests/core-notify.component.spec.ts

@@ -4,20 +4,18 @@ import {
   CORE_NOTIFIER_LAMBDA_LOG_GROUP_NAME,
   EVENT_BUS_LOG_GROUP_NAME,
 } from 'constants/backend-constants';
+import {
+  SENDER_ID_SKIPS_NOTIFY,
+  SENDER_ID_THAT_TRIGGERS_ERROR_IN_NOTIFY_SANDBOX,
+  SENDER_ID_VALID_FOR_NOTIFY_SANDBOX,
+} from 'config/component/senders.setup';
 import { PDMResourceAvailable } from 'digital-letters-events';
 import messagePDMResourceAvailableValidator from 'digital-letters-events/PDMResourceAvailable.js';
 import { getLogsFromCloudwatch } from 'helpers/cloudwatch-helpers';
 import eventPublisher from 'helpers/event-bus-helpers';
 import expectToPassEventually from 'helpers/expectations';
 import { expectMessageContainingString, purgeQueue } from 'helpers/sqs-helpers';
-import { SenderManagement } from 'sender-management';
 import { v4 as uuidv4 } from 'uuid';
-import { ParameterStoreCache } from 'utils';
-
-const senderIdInvokingNotify = 'componentTestSender_RoutingConfig';
-const senderIdThatTriggersErrorInNotifySandbox =
-  'componentTestSender_RoutingConfigInvalid';
-const senderIdThatSkipsNotify = 'componentTestSender_NoRoutingConfig';
 
 const baseEvent: Omit<PDMResourceAvailable, 'id' | 'data'> = {
   specversion: '1.0',
@@ -37,54 +35,13 @@ const baseEvent: Omit<PDMResourceAvailable, 'id' | 'data'> = {
 };
 
 test.describe('Digital Letters - Core Notify', () => {
-  const parameterStore = new ParameterStoreCache();
-  const senderManagement = SenderManagement({
-    parameterStore,
-  });
-
-  async function deleteSendersIfExist() {
-    senderManagement.deleteSender({ senderId: senderIdInvokingNotify });
-    senderManagement.deleteSender({
-      senderId: senderIdThatTriggersErrorInNotifySandbox,
-    });
-    senderManagement.deleteSender({ senderId: senderIdThatSkipsNotify });
-  }
-
   test.beforeAll(async () => {
     await purgeQueue(CORE_NOTIFIER_DLQ_NAME);
     test.setTimeout(250_000);
-
-    await deleteSendersIfExist();
-    senderManagement.putSender({
-      senderId: senderIdInvokingNotify,
-      senderName: 'componentTestSender_RoutingConfig',
-      meshMailboxSenderId: 'meshMailboxSender1',
-      meshMailboxReportsId: 'meshMailboxReports1',
-      routingConfigId: 'b838b13c-f98c-4def-93f0-515d4e4f4ee1',
-      fallbackWaitTimeSeconds: 100,
-    });
-
-    senderManagement.putSender({
-      senderId: senderIdThatTriggersErrorInNotifySandbox,
-      senderName: 'componentTestSender_RoutingConfig',
-      meshMailboxSenderId: 'meshMailboxSender2',
-      meshMailboxReportsId: 'meshMailboxReports2',
-      routingConfigId: 'invalid',
-      fallbackWaitTimeSeconds: 100,
-    });
-
-    senderManagement.putSender({
-      senderId: senderIdThatSkipsNotify,
-      senderName: 'componentTestSender_WithoutRoutingConfig',
-      meshMailboxSenderId: 'meshMailboxSender3',
-      meshMailboxReportsId: 'meshMailboxReports3',
-      fallbackWaitTimeSeconds: 100,
-    });
   });
 
   test.afterAll(async () => {
     await purgeQueue(CORE_NOTIFIER_DLQ_NAME);
-    await deleteSendersIfExist();
   });
 
   test('given PDMResourceAvailable event, when client has routingConfigId then a message is sent to core Notify', async () => {
@@ -99,7 +56,7 @@ test.describe('Digital Letters - Core Notify', () => {
           id: eventId,
           data: {
             messageReference,
-            senderId: senderIdInvokingNotify,
+            senderId: SENDER_ID_VALID_FOR_NOTIFY_SANDBOX,
             resourceId,
             nhsNumber: '9990548609',
             odsCode: 'A12345',
@@ -132,7 +89,7 @@ test.describe('Digital Letters - Core Notify', () => {
           `$.details.event_detail = "*\\"notifyId\\":\\"*\\"*"`,
           `$.details.event_detail = "*\\"messageUri\\":\\"https://www.nhsapp.service.nhs.uk/digital-letters?letterid=${resourceId}\\"*"`,
           `$.details.event_detail = "*\\"messageReference\\":\\"${messageReference}\\"*"`,
-          `$.details.event_detail = "*\\"senderId\\":\\"${senderIdInvokingNotify}\\"*"`,
+          `$.details.event_detail = "*\\"senderId\\":\\"${SENDER_ID_VALID_FOR_NOTIFY_SANDBOX}\\"*"`,
         ],
       );
 
@@ -152,7 +109,7 @@ test.describe('Digital Letters - Core Notify', () => {
           id: eventId,
           data: {
             messageReference,
-            senderId: senderIdThatTriggersErrorInNotifySandbox,
+            senderId: SENDER_ID_THAT_TRIGGERS_ERROR_IN_NOTIFY_SANDBOX,
             resourceId,
             nhsNumber: '9434765919',
             odsCode: 'A12345',
@@ -185,7 +142,7 @@ test.describe('Digital Letters - Core Notify', () => {
           `$.details.event_detail = "*\\"failureCode\\":\\"CM_INVALID_VALUE\\"*"`,
           `$.details.event_detail = "*\\"messageUri\\":\\"https://www.nhsapp.service.nhs.uk/digital-letters?letterid=${resourceId}\\"*"`,
           `$.details.event_detail = "*\\"messageReference\\":\\"${messageReference}\\"*"`,
-          `$.details.event_detail = "*\\"senderId\\":\\"${senderIdThatTriggersErrorInNotifySandbox}\\"*"`,
+          `$.details.event_detail = "*\\"senderId\\":\\"${SENDER_ID_THAT_TRIGGERS_ERROR_IN_NOTIFY_SANDBOX}\\"*"`,
         ],
       );
 
@@ -204,7 +161,7 @@ test.describe('Digital Letters - Core Notify', () => {
           id: eventId,
           data: {
             messageReference,
-            senderId: senderIdThatSkipsNotify,
+            senderId: SENDER_ID_SKIPS_NOTIFY,
             resourceId: 'resource-7777',
             nhsNumber: '9990548609',
             odsCode: 'A12345',
@@ -222,7 +179,7 @@ test.describe('Digital Letters - Core Notify', () => {
           '$.message_type = "EVENT_RECEIPT"',
           '$.details.detail_type = "uk.nhs.notify.digital.letters.messages.request.skipped.v1"',
           `$.details.event_detail = "*\\"messageReference\\":\\"${messageReference}\\"*"`,
-          `$.details.event_detail = "*\\"senderId\\":\\"${senderIdThatSkipsNotify}\\"*"`,
+          `$.details.event_detail = "*\\"senderId\\":\\"${SENDER_ID_SKIPS_NOTIFY}\\"*"`,
         ],
       );