@@ -16,6 +16,8 @@ import { v4 as uuidv4 } from 'uuid';
1616import { ParameterStoreCache } from 'utils' ;
1717
1818const senderIdInvokingNotify = 'componentTestSender_RoutingConfig' ;
19+ const senderIdInvokingNotifyRoutingInvalid =
20+ 'componentTestSender_RoutingConfigInvalid' ;
1921const senderIdThatSkipsNotify = 'componentTestSender_NoRoutingConfig' ;
2022
2123const baseEvent : Omit < PDMResourceAvailable , 'id' | 'data' > = {
@@ -44,6 +46,9 @@ test.describe('Digital Letters - Core Notify', () => {
4446
4547 async function deleteSendersIfExist ( ) {
4648 senderManagement . deleteSender ( { senderId : senderIdInvokingNotify } ) ;
49+ senderManagement . deleteSender ( {
50+ senderId : senderIdInvokingNotifyRoutingInvalid ,
51+ } ) ;
4752 senderManagement . deleteSender ( { senderId : senderIdThatSkipsNotify } ) ;
4853 }
4954
@@ -63,10 +68,19 @@ test.describe('Digital Letters - Core Notify', () => {
6368 } ) ;
6469
6570 senderManagement . putSender ( {
66- senderId : senderIdThatSkipsNotify ,
67- senderName : 'componentTestSender_WithoutRoutingConfig ' ,
71+ senderId : senderIdInvokingNotifyRoutingInvalid ,
72+ senderName : 'componentTestSender_RoutingConfig ' ,
6873 meshMailboxSenderId : 'meshMailboxSender2' ,
6974 meshMailboxReportsId : 'meshMailboxReports2' ,
75+ routingConfigId : 'invalid' ,
76+ fallbackWaitTimeSeconds : 100 ,
77+ } ) ;
78+
79+ senderManagement . putSender ( {
80+ senderId : senderIdThatSkipsNotify ,
81+ senderName : 'componentTestSender_WithoutRoutingConfig' ,
82+ meshMailboxSenderId : 'meshMailboxSender3' ,
83+ meshMailboxReportsId : 'meshMailboxReports3' ,
7084 fallbackWaitTimeSeconds : 100 ,
7185 } ) ;
7286 } ) ;
@@ -80,6 +94,7 @@ test.describe('Digital Letters - Core Notify', () => {
8094 test ( 'given PDMResourceAvailable event, when client has routingConfigId then a message is sent to core Notify' , async ( ) => {
8195 const eventId = uuidv4 ( ) ;
8296 const messageReference = uuidv4 ( ) ;
97+ const resourceId = 'resource-222' ;
8398
8499 await eventPublisher . sendEvents < PDMResourceAvailable > (
85100 [
@@ -89,7 +104,7 @@ test.describe('Digital Letters - Core Notify', () => {
89104 data : {
90105 messageReference,
91106 senderId : senderIdInvokingNotify ,
92- resourceId : 'resource-222' ,
107+ resourceId,
93108 nhsNumber : '9990548609' ,
94109 odsCode : 'A12345' ,
95110 } ,
@@ -119,7 +134,7 @@ test.describe('Digital Letters - Core Notify', () => {
119134 '$.message_type = "EVENT_RECEIPT"' ,
120135 '$.details.detail_type = "uk.nhs.notify.digital.letters.messages.request.submitted.v1"' ,
121136 `$.details.event_detail = "*\\"notifyId\\":\\"*\\"*"` ,
122- `$.details.event_detail = "*\\"messageUri\\":\\"https://www.nhsapp.service.nhs.uk/digital-letters?letterid=resource-222 \\"*"` ,
137+ `$.details.event_detail = "*\\"messageUri\\":\\"https://www.nhsapp.service.nhs.uk/digital-letters?letterid=${ resourceId } \\"*"` ,
123138 `$.details.event_detail = "*\\"messageReference\\":\\"${ messageReference } \\"*"` ,
124139 ] ,
125140 ) ;
@@ -128,9 +143,10 @@ test.describe('Digital Letters - Core Notify', () => {
128143 } , 240 ) ;
129144 } ) ;
130145
131- test ( 'given PDMResourceAvailable event with INVALID NHS Number , when client has routingConfigId then a message is sent to core Notify' , async ( ) => {
146+ test ( 'given PDMResourceAvailable event with INVALID Routing plan for the Sandbox , when client has routingConfigId then a message is sent to core Notify' , async ( ) => {
132147 const eventId = uuidv4 ( ) ;
133148 const messageReference = uuidv4 ( ) ;
149+ const resourceId = 'resource-999' ;
134150
135151 await eventPublisher . sendEvents < PDMResourceAvailable > (
136152 [
@@ -139,9 +155,9 @@ test.describe('Digital Letters - Core Notify', () => {
139155 id : eventId ,
140156 data : {
141157 messageReference,
142- senderId : senderIdInvokingNotify ,
143- resourceId : 'resource-999' ,
144- nhsNumber : '111 ' ,
158+ senderId : senderIdInvokingNotifyRoutingInvalid ,
159+ resourceId,
160+ nhsNumber : '9434765919 ' ,
145161 odsCode : 'A12345' ,
146162 } ,
147163 } ,
@@ -169,8 +185,8 @@ test.describe('Digital Letters - Core Notify', () => {
169185 [
170186 '$.message_type = "EVENT_RECEIPT"' ,
171187 '$.details.detail_type = "uk.nhs.notify.digital.letters.messages.request.rejected.v1"' ,
172- `$.details.event_detail = "*\\"failureCode\\":\\"CM_INVALID_NHS_NUMBER \\"*"` ,
173- `$.details.event_detail = "*\\"messageUri\\":\\"https://www.nhsapp.service.nhs.uk/digital-letters?letterid=resource-999 \\"*"` ,
188+ `$.details.event_detail = "*\\"failureCode\\":\\"CM_INVALID_VALUE \\"*"` ,
189+ `$.details.event_detail = "*\\"messageUri\\":\\"https://www.nhsapp.service.nhs.uk/digital-letters?letterid=${ resourceId } \\"*"` ,
174190 `$.details.event_detail = "*\\"messageReference\\":\\"${ messageReference } \\"*"` ,
175191 ] ,
176192 ) ;
0 commit comments