Skip to content

Commit b5b9cb2

Browse files
CCM-12858: updated error scenario
1 parent 43bfd3c commit b5b9cb2

1 file changed

Lines changed: 23 additions & 10 deletions

File tree

tests/playwright/digital-letters-component-tests/core-notify.component.spec.ts

Lines changed: 23 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import { v4 as uuidv4 } from 'uuid';
1616
import { ParameterStoreCache } from 'utils';
1717

1818
const senderIdInvokingNotify = 'componentTestSender_RoutingConfig';
19+
const senderIdInvokingNotifyRoutingInvalid = 'componentTestSender_RoutingConfigInvalid';
1920
const senderIdThatSkipsNotify = 'componentTestSender_NoRoutingConfig';
2021

2122
const baseEvent: Omit<PDMResourceAvailable, 'id' | 'data'> = {
@@ -44,6 +45,7 @@ test.describe('Digital Letters - Core Notify', () => {
4445

4546
async function deleteSendersIfExist() {
4647
senderManagement.deleteSender({ senderId: senderIdInvokingNotify });
48+
senderManagement.deleteSender({ senderId: senderIdInvokingNotifyRoutingInvalid });
4749
senderManagement.deleteSender({ senderId: senderIdThatSkipsNotify });
4850
}
4951

@@ -63,10 +65,19 @@ test.describe('Digital Letters - Core Notify', () => {
6365
});
6466

6567
senderManagement.putSender({
66-
senderId: senderIdThatSkipsNotify,
67-
senderName: 'componentTestSender_WithoutRoutingConfig',
68+
senderId: senderIdInvokingNotifyRoutingInvalid,
69+
senderName: 'componentTestSender_RoutingConfig',
6870
meshMailboxSenderId: 'meshMailboxSender2',
6971
meshMailboxReportsId: 'meshMailboxReports2',
72+
routingConfigId: 'invalid',
73+
fallbackWaitTimeSeconds: 100,
74+
});
75+
76+
senderManagement.putSender({
77+
senderId: senderIdThatSkipsNotify,
78+
senderName: 'componentTestSender_WithoutRoutingConfig',
79+
meshMailboxSenderId: 'meshMailboxSender3',
80+
meshMailboxReportsId: 'meshMailboxReports3',
7081
fallbackWaitTimeSeconds: 100,
7182
});
7283
});
@@ -80,6 +91,7 @@ test.describe('Digital Letters - Core Notify', () => {
8091
test('given PDMResourceAvailable event, when client has routingConfigId then a message is sent to core Notify', async () => {
8192
const eventId = uuidv4();
8293
const messageReference = uuidv4();
94+
const resourceId = 'resource-222';
8395

8496
await eventPublisher.sendEvents<PDMResourceAvailable>(
8597
[
@@ -89,7 +101,7 @@ test.describe('Digital Letters - Core Notify', () => {
89101
data: {
90102
messageReference,
91103
senderId: senderIdInvokingNotify,
92-
resourceId: 'resource-222',
104+
resourceId ,
93105
nhsNumber: '9990548609',
94106
odsCode: 'A12345',
95107
},
@@ -119,7 +131,7 @@ test.describe('Digital Letters - Core Notify', () => {
119131
'$.message_type = "EVENT_RECEIPT"',
120132
'$.details.detail_type = "uk.nhs.notify.digital.letters.messages.request.submitted.v1"',
121133
`$.details.event_detail = "*\\"notifyId\\":\\"*\\"*"`,
122-
`$.details.event_detail = "*\\"messageUri\\":\\"https://www.nhsapp.service.nhs.uk/digital-letters?letterid=resource-222\\"*"`,
134+
`$.details.event_detail = "*\\"messageUri\\":\\"https://www.nhsapp.service.nhs.uk/digital-letters?letterid=${resourceId}\\"*"`,
123135
`$.details.event_detail = "*\\"messageReference\\":\\"${messageReference}\\"*"`,
124136
],
125137
);
@@ -128,9 +140,10 @@ test.describe('Digital Letters - Core Notify', () => {
128140
}, 240);
129141
});
130142

131-
test('given PDMResourceAvailable event with INVALID NHS Number, when client has routingConfigId then a message is sent to core Notify', async () => {
143+
test('given PDMResourceAvailable event with INVALID Routing plan for the Sandbox, when client has routingConfigId then a message is sent to core Notify', async () => {
132144
const eventId = uuidv4();
133145
const messageReference = uuidv4();
146+
const resourceId = 'resource-999';
134147

135148
await eventPublisher.sendEvents<PDMResourceAvailable>(
136149
[
@@ -139,9 +152,9 @@ test.describe('Digital Letters - Core Notify', () => {
139152
id: eventId,
140153
data: {
141154
messageReference,
142-
senderId: senderIdInvokingNotify,
143-
resourceId: 'resource-999',
144-
nhsNumber: '111',
155+
senderId: senderIdInvokingNotifyRoutingInvalid,
156+
resourceId,
157+
nhsNumber: '9434765919',
145158
odsCode: 'A12345',
146159
},
147160
},
@@ -169,8 +182,8 @@ test.describe('Digital Letters - Core Notify', () => {
169182
[
170183
'$.message_type = "EVENT_RECEIPT"',
171184
'$.details.detail_type = "uk.nhs.notify.digital.letters.messages.request.rejected.v1"',
172-
`$.details.event_detail = "*\\"failureCode\\":\\"CM_INVALID_NHS_NUMBER\\"*"`,
173-
`$.details.event_detail = "*\\"messageUri\\":\\"https://www.nhsapp.service.nhs.uk/digital-letters?letterid=resource-999\\"*"`,
185+
`$.details.event_detail = "*\\"failureCode\\":\\"CM_INVALID_VALUE\\"*"`,
186+
`$.details.event_detail = "*\\"messageUri\\":\\"https://www.nhsapp.service.nhs.uk/digital-letters?letterid=${resourceId}\\"*"`,
174187
`$.details.event_detail = "*\\"messageReference\\":\\"${messageReference}\\"*"`,
175188
],
176189
);

0 commit comments

Comments
 (0)