Skip to content

Fix README CI badges and add prominent docs link - #1152

Merged
justin808 merged 1 commit into
mainfrom
jg-conductor/readme-badges-docs-link
May 30, 2026
Merged

Fix README CI badges and add prominent docs link#1152
justin808 merged 1 commit into
mainfrom
jg-conductor/readme-badges-docs-link

Conversation

@justin808

@justin808 justin808 commented May 29, 2026

Copy link
Copy Markdown
Member

Problem

The four CI status badges at the top of the README were rendering blank ("no status"):

Ruby based checks · Jest specs · Rubocop · JS lint

They used the legacy workflow-name badge URLs (/workflows/<Name>/badge.svg). Only Ruby based checks still matched a real workflow. There are no longer standalone workflows named Jest specs, Rubocop, or JS lint — Jest and ESLint are jobs inside Node based checks (node.yml), and RuboCop is a job inside Ruby based checks (ruby.yml). GitHub badges are per-workflow (not per-job), so those three showed "no status".

Fix

Repoint all four badges to real workflows that run on main, using the current file-path badge URL format so each reports live pass/fail status and links to its workflow runs:

Badge Workflow Covers
Ruby based checks ruby.yml Ruby specs, RuboCop, RBS
Node based checks node.yml Jest, ESLint (JS lint), Prettier, TypeScript
Generator specs generator.yml Installer/generator specs
Test Both Bundlers test-bundlers.yml webpack + Rspack dummy-app specs

RuboCop / JS lint / Jest are surfaced through the umbrella workflows that actually own those jobs.

Verified the new badge endpoints return real status (passing/failing) instead of no status.

Docs link

Added a large, bold 📖 Read the Docs button near the top linking to shakapacker.com/docs, and removed the now-redundant inline "Full documentation lives at…" sentence in the intro (the dedicated Documentation section below still has it).

🤖 Generated with Claude Code


Note

Low Risk
Documentation and badge URL changes only; no runtime, CI workflow, or application code is modified.

Overview
Updates the README so CI status badges reflect real GitHub Actions workflows and the docs site is easier to find from the top of the page.

CI badges are switched from legacy workflow-name URLs (which left Jest specs, Rubocop, and JS lint showing “no status”) to the current actions/workflows/<file>.yml/badge.svg links for Ruby based checks, Node based checks, Generator specs, and Test Both Bundlers, each pointing at the matching workflow run page.

A centered Read the Docs shield button links to shakapacker.com/docs. The redundant intro sentence that duplicated that link is removed; the Documentation section below is unchanged.

Reviewed by Cursor Bugbot for commit 099b961. Bugbot is set up for automated code reviews on this repo. Configure here.

The Ruby/Jest/Rubocop/JS-lint status badges used the legacy
workflow-name badge URLs. Only "Ruby based checks" still matched a real
workflow; "Jest specs", "Rubocop", and "JS lint" no longer exist as
standalone workflows (Jest and ESLint are jobs in node.yml, RuboCop is a
job in ruby.yml), so those three rendered "no status".

Repoint all four to real workflows that run on main, using the current
file-path badge URL format so they report live pass/fail status:
ruby.yml, node.yml, generator.yml, and test-bundlers.yml.

Also add a large "Read the Docs" button near the top linking to
shakapacker.com/docs, and drop the now-redundant inline docs sentence.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@justin808, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 7 minutes and 6 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 51c1cc41-a2c6-4ded-a4fa-a42c20718cc3

📥 Commits

Reviewing files that changed from the base of the PR and between d602ede and 099b961.

📒 Files selected for processing (1)
  • README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-conductor/readme-badges-docs-link

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes four CI status badges in the README that were rendering as "no status" because they used the legacy /workflows/<Name>/badge.svg format with names that no longer matched real workflows. It replaces them with the current /actions/workflows/<file>.yml/badge.svg format pointing to four verified workflow files. A prominent "Read the Docs" shield badge is also added near the top.

  • All four referenced workflow files (ruby.yml, node.yml, generator.yml, test-bundlers.yml) exist in .github/workflows/, confirming the new badge URLs are valid.
  • The redundant inline docs sentence ("Full documentation lives at…") is removed since the new button and the existing Documentation section already cover it.

Confidence Score: 5/5

README-only change that corrects broken badge URLs and adds a docs link button — no code, logic, or configuration is touched.

All four workflow files referenced by the new badge URLs exist in .github/workflows/. The badge URL format change from legacy name-based to file-path-based is the correct GitHub-documented approach. No functional code is affected.

No files require special attention.

Important Files Changed

Filename Overview
README.md Replaces broken legacy workflow-name badge URLs with correct file-path badge URLs pointing to existing workflow files, adds a "Read the Docs" button, and removes a now-redundant docs link sentence.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[README.md badge click] --> B{Badge URL format}
    B -- Old: /workflows/Name/badge.svg --> C[GitHub resolves by workflow name]
    C --> D{Name match?}
    D -- Jest specs / Rubocop / JS lint --> E[❌ No status - workflow not found]
    D -- Ruby based checks --> F[✅ Status shown]
    B -- New: /actions/workflows/file.yml/badge.svg --> G[GitHub resolves by file path]
    G --> H{File exists?}
    H -- ruby.yml / node.yml / generator.yml / test-bundlers.yml --> I[✅ Live pass/fail status]
Loading

Reviews (1): Last reviewed commit: "Fix CI badges and add prominent docs lin..." | Re-trigger Greptile

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@justin808
justin808 merged commit 336df13 into main May 30, 2026
3 checks passed
@justin808
justin808 deleted the jg-conductor/readme-badges-docs-link branch May 30, 2026 02:32
justin808 added a commit that referenced this pull request Jun 9, 2026
…nalyze-webpack-output

* origin/main: (164 commits)
  Make Rspack the default bundler for new installs (#1150)
  Add "Why Shakapacker with Rspack" comparison guide (#1155)
  Support sass-loader v17 (#1141)
  [codex] Fix Claude workflow permissions (#1153)
  Fix README CI badges and add prominent docs link (#1152)
  Trim README into a docs-site index; relocate content to docs/ and fix deep links (#1148)
  Tighten helper binstub parity and PATH lookup (#1128)
  Optimize CI: minimal version matrix on PRs, full matrix on main (#1151)
  Fix instance-scoped compiler strategies (#1147)
  Fix Rspack devServer in static watch mode (#1142)
  Add homepage links for supplemental npm packages (#1145)
  Release 10.1.0
  Update CHANGELOG.md for v10.1.0 (#1139)
  Expand prerelease-to-stable changelog coalesce guidance in /update-changelog (#1138)
  Release 10.1.0-rc.2
  [codex] Update changelog for v10.1.0-rc.2 (#1136)
  Teach /update-changelog to drop RC-only regression fixes (#1125)
  Restructure supplemental package dependencies (#1131) (#1133)
  [codex] Add Shakapacker brand assets (#1135)
  [codex] Fix shakapacker config helper binstubs (#1132)
  ...
justin808 added a commit that referenced this pull request Jun 29, 2026
* origin/main: (26 commits)
  Adopt agent-workflow binstubs (.agents/bin/ + AGENTS.md pointer) (#1176)
  Fix Ruby 3.1 CI: exclude broken i18n 1.15.0/1.15.1 (Fiber[]) (#1171)
  Add AI analysis prompt generator to config exporter (#695)
  Make Rspack the default bundler for new installs (#1150)
  Add "Why Shakapacker with Rspack" comparison guide (#1155)
  Support sass-loader v17 (#1141)
  [codex] Fix Claude workflow permissions (#1153)
  Fix README CI badges and add prominent docs link (#1152)
  Trim README into a docs-site index; relocate content to docs/ and fix deep links (#1148)
  Tighten helper binstub parity and PATH lookup (#1128)
  Optimize CI: minimal version matrix on PRs, full matrix on main (#1151)
  Fix instance-scoped compiler strategies (#1147)
  Fix Rspack devServer in static watch mode (#1142)
  Add homepage links for supplemental npm packages (#1145)
  Release 10.1.0
  Update CHANGELOG.md for v10.1.0 (#1139)
  Expand prerelease-to-stable changelog coalesce guidance in /update-changelog (#1138)
  Release 10.1.0-rc.2
  [codex] Update changelog for v10.1.0-rc.2 (#1136)
  Teach /update-changelog to drop RC-only regression fixes (#1125)
  ...

# Conflicts:
#	CHANGELOG.md
#	lib/install/bin/diff-bundler-config
#	lib/install/bin/shakapacker-config
#	lib/tasks/shakapacker/export_bundler_config.rake
#	package/configExporter/cli.ts
#	spec/dummy/bin/shakapacker-config
justin808 added a commit that referenced this pull request Jul 4, 2026
## Summary

Stamps the **`v10.2.0`** release section in `CHANGELOG.md` and adds the
user-visible entries that were still missing for PRs merged since
`v10.1.0`.

Header format matches the repo convention (`## [v10.2.0] - July 3,
2026`) and is parseable by `rakelib/release.rake`'s
`extract_changelog_section` (`## [v<npm-version>]`), so `bundle exec
rake release` / `sync_github_release` will pick up the notes
automatically.

### Changelog changes

- **Version header**: inserted `## [v10.2.0] - July 3, 2026` immediately
after `## [Unreleased]`; all accumulated entries now live under it, and
`## [Unreleased]` is empty.
- **Compare links**: `[unreleased]` now compares `v10.2.0...main`; added
`[v10.2.0]: …/compare/v10.1.0...v10.2.0`.

### New entries added (were missing)

| PR | Section | Note |
| --- | --- | --- |
| [#1187](#1187) | Added |
Babel 8 peer dependency support + preset option compatibility |
| [#1184](#1184) | Added |
Folded into the #695 AI-prompt entry (gates the React on Rails section
on app detection) |
| [#1142](#1142) | Fixed |
Rspack dev-server config no longer loads in static watch mode (fixes
#1137) |

### Already documented (carried into v10.2.0)

`#1180`, `#695`, `#1141`, `#1150`, `#1179`, `#1192`, `#1127`, `#1178`,
`#1161`, `#1147`.

### Reviewed and intentionally excluded (not user-visible)

Docs: `#1145`, `#1148`, `#1152`, `#1155`, `#1183`, `#1188`, `#1189`,
`#1193`.
CI: `#1151`, `#1168`, `#1171`.
Tests / fixtures: `#1128`, `#1154`, `#1167`, `#1186`.
Workflow / agent tooling: `#1153`, `#1176`, `#1182`.

(`#1107` is already documented under `## [v10.1.0]`.)

## Next step

After merge, run the repo's release task (no args) — it reads `v10.2.0`
from the changelog and creates the GitHub release from this section.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant