Replace helper binstub sync note - #1183
Conversation
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThe maintainer-only "keep helper logic in sync" comment in four synchronized binstub files/templates is replaced with a user-facing "managed by Shakapacker" regeneration notice. The associated parity test is updated to assert the new comment's presence and the old comment's absence. ChangesBinstub Header Comment Update
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR updates the helper binstub note shown in distributed and generated files. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "Use user-facing helper binstub comment" | Re-trigger Greptile |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
ReviewSmall, focused change: replaces the maintainer-only "keep these files in sync" comment inside the four generated/checked-in Verified:
One accuracy issue (left as an inline comment): the new comment claims "Regenerate it by rerunning the install or init command," but Otherwise this looks good — minimal, well-tested, and in line with the project's "convention over configuration" / focused-PR guidelines. |
ReviewSmall, well-scoped change — replaces the maintainer-facing "keep these 4 files in sync" comment (which leaked internal repo paths like
Minor nits (non-blocking)
No bugs, security issues, or performance concerns found. LGTM. |
## Summary Stamps the **`v10.2.0`** release section in `CHANGELOG.md` and adds the user-visible entries that were still missing for PRs merged since `v10.1.0`. Header format matches the repo convention (`## [v10.2.0] - July 3, 2026`) and is parseable by `rakelib/release.rake`'s `extract_changelog_section` (`## [v<npm-version>]`), so `bundle exec rake release` / `sync_github_release` will pick up the notes automatically. ### Changelog changes - **Version header**: inserted `## [v10.2.0] - July 3, 2026` immediately after `## [Unreleased]`; all accumulated entries now live under it, and `## [Unreleased]` is empty. - **Compare links**: `[unreleased]` now compares `v10.2.0...main`; added `[v10.2.0]: …/compare/v10.1.0...v10.2.0`. ### New entries added (were missing) | PR | Section | Note | | --- | --- | --- | | [#1187](#1187) | Added | Babel 8 peer dependency support + preset option compatibility | | [#1184](#1184) | Added | Folded into the #695 AI-prompt entry (gates the React on Rails section on app detection) | | [#1142](#1142) | Fixed | Rspack dev-server config no longer loads in static watch mode (fixes #1137) | ### Already documented (carried into v10.2.0) `#1180`, `#695`, `#1141`, `#1150`, `#1179`, `#1192`, `#1127`, `#1178`, `#1161`, `#1147`. ### Reviewed and intentionally excluded (not user-visible) Docs: `#1145`, `#1148`, `#1152`, `#1155`, `#1183`, `#1188`, `#1189`, `#1193`. CI: `#1151`, `#1168`, `#1171`. Tests / fixtures: `#1128`, `#1154`, `#1167`, `#1186`. Workflow / agent tooling: `#1153`, `#1176`, `#1182`. (`#1107` is already documented under `## [v10.1.0]`.) ## Next step After merge, run the repo's release task (no args) — it reads `v10.2.0` from the changelog and creates the GitHub release from this section. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
## Summary Adds a repo-owned merge readiness helper and checklist entry so the current-head merge gate checks the full `gh pr checks` list, unresolved review threads, mergeability, and replay timing rather than only required checks. Closes #1196. ## Validation - `ruby -c .agents/bin/merge-readiness-check` - `bundle exec rubocop .agents/bin/merge-readiness-check` - `.agents/bin/merge-readiness-check 1183 --repo shakacode/shakapacker` returned `MERGE_READINESS_NOT_READY` and caught 19 checks completing after the merge timestamp. - `.agents/bin/merge-readiness-check 1207 --repo shakacode/shakapacker` returned `MERGE_READINESS_READY` for a clean merged PR. - `git diff --check origin/main...HEAD` ## Gate / Replay Evidence - Mechanism target: `checklist+replay`. - Motivating miss: PR #1183 merged at `2026-07-01T04:54:08Z` before the full current-head check/review-agent set settled. - Replay control: `.agents/bin/merge-readiness-check 1183 --repo shakacode/shakapacker` fails because current-head checks including `validate`, `test`, `claude-review`, and matrix jobs completed after the merge timestamp. - Stale-base control: the new helper lives in `.agents/bin` and the PR template points future PRs at the current-head command; the historical replay proves the mechanism catches the motivating stale/current-head timing miss before this gate text lands. - Non-goal: this does not make AI reviewers maintainer approvers; it only requires their configured checks/comments to be completed and triaged before merge. ## Notes This is a workflow/helper-script change, not application runtime code. `CHANGELOG.md` is unchanged because this is process tooling, not a user-visible package change.
1 participant
Summary
Closes #1149
Validation
PATH=/Users/justin/.local/share/mise/installs/node/22.20.0/bin:/Users/justin/.local/share/mise/installs/yarn/1.22.22/bin:$PATH yarn test test/configExporter/createBinStub.test.js --runInBandPATH=/Users/justin/.local/share/mise/installs/node/22.20.0/bin:/Users/justin/.local/share/mise/installs/yarn/1.22.22/bin:$PATH bundle exec rspec spec/shakapacker/binstub_sync_spec.rbPATH=/Users/justin/.local/share/mise/installs/node/22.20.0/bin:/Users/justin/.local/share/mise/installs/yarn/1.22.22/bin:$PATH yarn lintcodex review --base origin/maincleanNotes
.agents/bin/validatewas attempted; RuboCop completed with no offenses, then the wrapper entered a localmise node@22.20.0 install/npm -vhang. Targeted Ruby and JS checks above were run with the direct Node/Yarn path.Summary by CodeRabbit
Chores
Tests