Skip to content

[codex] Update changelog for v10.1.0-rc.2 - #1136

Merged
justin808 merged 1 commit into
mainfrom
jg-conductor/changelog-v10-1-0-rc-2
May 24, 2026
Merged

[codex] Update changelog for v10.1.0-rc.2#1136
justin808 merged 1 commit into
mainfrom
jg-conductor/changelog-v10-1-0-rc-2

Conversation

@justin808

@justin808 justin808 commented May 24, 2026

Copy link
Copy Markdown
Member

Summary

Updates CHANGELOG.md for v10.1.0-rc.2 by collapsing the prior v10.1.0-rc.1 prerelease notes into the new section, moving PR #1133 from Unreleased into Changed, and adding the PR #1132 config helper binstub/export task fix.
The release compare links now point Unreleased from v10.1.0-rc.2 and compare v10.0.0...v10.1.0-rc.2.

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

Other Information

Validated with yarn lint, git diff --check, and review of git diff origin/main....


Note

Low Risk
Documentation-only change updating release notes and compare links; no runtime code or dependency changes in this PR.

Overview
Updates CHANGELOG.md to publish v10.1.0-rc.2 by moving the prior prerelease content under the new version header, adding the shakapacker:export_bundler_config/binstub fix entry (PR #1132), and relocating the dependency declaration change (PR #1133) from Unreleased into Changed.

Also updates the bottom compare links so Unreleased now compares from v10.1.0-rc.2 and adds the v10.1.0-rc.2 tag comparison link.

Reviewed by Cursor Bugbot for commit 4d4dfea. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented May 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@justin808, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 2 reviews/hour. Refill in 17 minutes and 19 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dd4b1c59-677c-4ce1-9c2c-54a482b147eb

📥 Commits

Reviewing files that changed from the base of the PR and between 843f18b and 4d4dfea.

📒 Files selected for processing (1)
  • CHANGELOG.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-conductor/changelog-v10-1-0-rc-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@justin808
justin808 marked this pull request as ready for review May 24, 2026 03:31
@justin808
justin808 merged commit e29372b into main May 24, 2026
5 checks passed
@justin808
justin808 deleted the jg-conductor/changelog-v10-1-0-rc-2 branch May 24, 2026 03:31
@greptile-apps

greptile-apps Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR publishes v10.1.0-rc.2 release notes by folding the prior v10.1.0-rc.1 section into the new version header (dated May 23, 2026), promoting the dependency-restructuring entry (PR #1133) from Unreleased into Changed, and adding the config-helper binstub/export-task fix (PR #1132) to Fixed.

  • The [Unreleased] section is now empty and correctly tracks from v10.1.0-rc.2...main.
  • The bottom compare link for [v10.1.0-rc.2] spans v10.0.0...v10.1.0-rc.2, which is appropriate since all rc content is consolidated under this single section with no separate rc.1 entry.

Confidence Score: 5/5

Documentation-only change to CHANGELOG.md with no runtime code, configuration, or dependency modifications.

The PR touches only CHANGELOG.md. The version header, date, PR entries, and compare links are all internally consistent — the rc.1-to-rc.2 rename is reflected everywhere (section header, footer compare link, and the Unreleased tracking link). No logic, gem code, or JavaScript is modified.

No files require special attention.

Important Files Changed

Filename Overview
CHANGELOG.md Renames v10.1.0-rc.1 section to v10.1.0-rc.2, moves PR #1133 from Unreleased into Changed, adds PR #1132 to Fixed, and updates bottom compare links — no code changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["[Unreleased]<br/>(empty)"] -->|compare link| B["v10.1.0-rc.2...main"]
    C["[v10.1.0-rc.2] - May 23, 2026"] --> D["Added<br/>(unchanged from rc.1)"]
    C --> E["Changed<br/>+ PR #1133 moved from Unreleased"]
    C --> F["Fixed<br/>+ PR #1132 newly added"]
    G["Compare links"] --> H["Unreleased: rc.2...main"]
    G --> I["v10.1.0-rc.2: v10.0.0...v10.1.0-rc.2"]
Loading

Reviews (1): Last reviewed commit: "Update CHANGELOG.md for v10.1.0-rc.2" | Re-trigger Greptile

@claude

claude Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

Code Review: CHANGELOG update for v10.1.0-rc.2

Summary: Documentation-only PR that promotes the rc.1 prerelease section to rc.2, moves PR #1133 from Unreleased into Changed, and adds the PR #1132 binstub/export-task fix entry. Clean and focused.

What looks good

  • The diff is minimal and purposeful — exactly what a changelog bump should look like.
  • Moving PR Restructure supplemental package dependencies (#1131) #1133 from Unreleased into the versioned section is correct: it was already merged and shipped in rc.1, so it belongs under a version header, not Unreleased.
  • The small formatting fix (adding . between the bold description and the [PR #...] reference) makes the new entries consistent with every other entry in the Changed/Fixed sections.
  • Compare links at the bottom are updated consistently.

One observation worth noting for future rc releases

The compare link for [v10.1.0-rc.2] points to v10.0.0...v10.1.0-rc.2 rather than v10.1.0-rc.1...v10.1.0-rc.2. This is a deliberate choice (collapsing the rc.1 section entirely into rc.2), and it is correct given that the rc.2 changelog section now represents all changes since v10.0.0.

The one side-effect is that the v10.1.0-rc.1 git tag (if it exists) now has no corresponding changelog entry or compare link. Anyone who pinned rc.1 and wants to diff against rc.2 would need to construct the GitHub compare URL manually. This is unlikely to be a problem in practice for a prerelease, but it is worth being aware of if rc.1 saw any real-world usage.

Verdict

Approved. Changes are correct, minimal, and follow the project's changelog conventions. No runtime code is touched.

@claude

claude Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

Code Review — CHANGELOG update for v10.1.0-rc.2

This PR is documentation-only (CHANGELOG.md, +5/-7 lines) and is already merged. Notes for the record:

What the PR does

Observations

Minor: v10.1.0-rc.1 compare link removed entirely.

The footer previously had:

[v10.1.0-rc.1]: https://github.com/shakacode/shakapacker/compare/v10.0.0...v10.1.0-rc.1

This line was dropped rather than preserved alongside the rc.2 entry. The v10.1.0-rc.1 git tag still exists on GitHub, so the link would still resolve if kept. Anyone who pinned to rc.1 and checks the changelog won't find a named diff link for that tag. For an already-superseded prerelease this is low-stakes, but retaining the old footer line as a historical entry is common practice. Consider adding it back in a follow-up if rc.1 was ever communicated externally.

Formatting improvement noted. The PR #1133 entry gains a period after the closing bold marker (**.** [) when moved from Unreleased into Changed, which aligns it with every other entry in the section. Good catch.

Content accuracy looks correct. All PRs referenced (#1132, #1133) are real merged PRs on this repo, dates are plausible, and the compare URLs match the footer.

Verdict

No correctness issues. The only potential follow-up is preserving the [v10.1.0-rc.1] footer link for historical completeness.

justin808 added a commit that referenced this pull request Jun 9, 2026
…nalyze-webpack-output

* origin/main: (164 commits)
  Make Rspack the default bundler for new installs (#1150)
  Add "Why Shakapacker with Rspack" comparison guide (#1155)
  Support sass-loader v17 (#1141)
  [codex] Fix Claude workflow permissions (#1153)
  Fix README CI badges and add prominent docs link (#1152)
  Trim README into a docs-site index; relocate content to docs/ and fix deep links (#1148)
  Tighten helper binstub parity and PATH lookup (#1128)
  Optimize CI: minimal version matrix on PRs, full matrix on main (#1151)
  Fix instance-scoped compiler strategies (#1147)
  Fix Rspack devServer in static watch mode (#1142)
  Add homepage links for supplemental npm packages (#1145)
  Release 10.1.0
  Update CHANGELOG.md for v10.1.0 (#1139)
  Expand prerelease-to-stable changelog coalesce guidance in /update-changelog (#1138)
  Release 10.1.0-rc.2
  [codex] Update changelog for v10.1.0-rc.2 (#1136)
  Teach /update-changelog to drop RC-only regression fixes (#1125)
  Restructure supplemental package dependencies (#1131) (#1133)
  [codex] Add Shakapacker brand assets (#1135)
  [codex] Fix shakapacker config helper binstubs (#1132)
  ...
justin808 added a commit that referenced this pull request Jun 29, 2026
* origin/main: (26 commits)
  Adopt agent-workflow binstubs (.agents/bin/ + AGENTS.md pointer) (#1176)
  Fix Ruby 3.1 CI: exclude broken i18n 1.15.0/1.15.1 (Fiber[]) (#1171)
  Add AI analysis prompt generator to config exporter (#695)
  Make Rspack the default bundler for new installs (#1150)
  Add "Why Shakapacker with Rspack" comparison guide (#1155)
  Support sass-loader v17 (#1141)
  [codex] Fix Claude workflow permissions (#1153)
  Fix README CI badges and add prominent docs link (#1152)
  Trim README into a docs-site index; relocate content to docs/ and fix deep links (#1148)
  Tighten helper binstub parity and PATH lookup (#1128)
  Optimize CI: minimal version matrix on PRs, full matrix on main (#1151)
  Fix instance-scoped compiler strategies (#1147)
  Fix Rspack devServer in static watch mode (#1142)
  Add homepage links for supplemental npm packages (#1145)
  Release 10.1.0
  Update CHANGELOG.md for v10.1.0 (#1139)
  Expand prerelease-to-stable changelog coalesce guidance in /update-changelog (#1138)
  Release 10.1.0-rc.2
  [codex] Update changelog for v10.1.0-rc.2 (#1136)
  Teach /update-changelog to drop RC-only regression fixes (#1125)
  ...

# Conflicts:
#	CHANGELOG.md
#	lib/install/bin/diff-bundler-config
#	lib/install/bin/shakapacker-config
#	lib/tasks/shakapacker/export_bundler_config.rake
#	package/configExporter/cli.ts
#	spec/dummy/bin/shakapacker-config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant