Skip to content

Support Rails 7.0 - #1517

Merged
booleanbetrayal merged 1 commit into
lynndylanhurley:masterfrom
enomotodev:patch-rails7
Dec 29, 2021
Merged

Support Rails 7.0#1517
booleanbetrayal merged 1 commit into
lynndylanhurley:masterfrom
enomotodev:patch-rails7

Conversation

@enomotodev

@enomotodev enomotodev commented Dec 22, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@enomotodev
enomotodev marked this pull request as ready for review December 22, 2021 09:25
@agildav agildav mentioned this pull request Dec 22, 2021
Closed
@artplan1 artplan1 mentioned this pull request Dec 23, 2021
Merged
@booleanbetrayal

booleanbetrayal commented Dec 29, 2021

Copy link
Copy Markdown
Collaborator

I have not had a chance to do any integration testing with this branch (looks like others may have), but I'm fine getting it into master for easier iteration.

@booleanbetrayal
booleanbetrayal merged commit 5b1a5e1 into lynndylanhurley:master Dec 29, 2021
@mbackermann

mbackermann commented Dec 29, 2021

Copy link
Copy Markdown

There's a known issue with devise working with api only on rails 7. I reported it this week
heartcombo/devise#5443

This bug may affect this PR.

@booleanbetrayal

booleanbetrayal commented Dec 29, 2021

Copy link
Copy Markdown
Collaborator

There's a known issue with devise working with api only on rails 7. I reported it this week heartcombo/devise#5443

This bug may affect this PR.

Thanks @mbackermann - Hopefully relaxing the gemspec constraint in master helps to generate incentive for people to help fix that upstream Devise issue.

@enomotodev
enomotodev deleted the patch-rails7 branch December 29, 2021 02:24
@Petercopter

Petercopter commented Jan 2, 2022

Copy link
Copy Markdown

Will there be a new release cut for this change, or should we be testing against master?

@booleanbetrayal

booleanbetrayal commented Jan 2, 2022

Copy link
Copy Markdown
Collaborator

@Petercopter - It would be nice to get some additional confirmation around Rails 7 interop before bumping gem versions, especially given the known issue with Devise. Probably prudent to let it simmer in master for a bit.

@mcelicalderon mcelicalderon mentioned this pull request Jan 3, 2022
Merged
@mcelicalderon mcelicalderon mentioned this pull request Jan 13, 2022
Closed
@mcelicalderon mcelicalderon mentioned this pull request Jan 22, 2022
Merged
@simukappu simukappu mentioned this pull request Feb 11, 2022
Closed
@mcelicalderon

mcelicalderon commented Jun 11, 2022

Copy link
Copy Markdown
Contributor

@mbackermann is there any update on the issue with devise?

@MaicolBen MaicolBen mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@booleanbetrayal booleanbetrayal booleanbetrayal approved these changes
+3 more reviewers
@mbackermann mbackermann mbackermann approved these changes
@artplan1 artplan1 artplan1 approved these changes
@connortorrell connortorrell connortorrell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@enomotodev @booleanbetrayal @mbackermann @Petercopter @mcelicalderon @artplan1 @connortorrell