Skip to content

Add support for graphql 1.13#205

Merged
mcelicalderon merged 1 commit intomasterfrom
support-graphql-1.13
Jan 3, 2022
Merged

Add support for graphql 1.13#205
mcelicalderon merged 1 commit intomasterfrom
support-graphql-1.13

Conversation

@mcelicalderon
Copy link
Copy Markdown
Member

@mcelicalderon mcelicalderon commented Jan 3, 2022

Adds support for graphql 1.13

Fixes test matrix and appraisals. Temporarily skipping rails 7.0. Spec support will be fixed in a follow up PR

@mcelicalderon mcelicalderon added the enhancement New feature or request label Jan 3, 2022
@mcelicalderon mcelicalderon requested a review from 00dav00 January 3, 2022 20:59
@mcelicalderon mcelicalderon force-pushed the support-graphql-1.13 branch 2 times, most recently from 6910394 to 7ea52b7 Compare January 3, 2022 21:11
@mcelicalderon
Copy link
Copy Markdown
Member Author

@00dav00 can you please take a look? I had to disable testing Rails 7.0 temporarily to fix master. Will fix in a follow up MR, there seems to be something wrong with the generator.

@mcelicalderon mcelicalderon merged commit ca345f3 into master Jan 3, 2022
@mcelicalderon mcelicalderon deleted the support-graphql-1.13 branch January 3, 2022 23:52
@janraasch
Copy link
Copy Markdown
Contributor

Hi there 👋, thank you for your work on this nice gem 👍 🙏. Do you have en ETA for when you'll be able to release a version of graphql_devise sporting that sweet graphql 1.13-version support 🤓?

@mcelicalderon
Copy link
Copy Markdown
Member Author

Hey @janraasch! Sorry this got lost in master. We've been waiting to do a bigger release with everything in master, but perhaps we can release this change separately. I'll try to do so later today, no reason to delay support for 1.13 as no code changes were actually required

@janraasch
Copy link
Copy Markdown
Contributor

Sounds great, @mcelicalderon 💜. Thank you!

@mcelicalderon
Copy link
Copy Markdown
Member Author

v0.18.0 released with graphql 1.13 support @janraasch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants