Skip to content

Rails 7 support - #203

Merged
mcelicalderon merged 2 commits into
graphql-devise:masterfrom
artplan1:rails-7
Jan 3, 2022
Merged

Rails 7 support#203
mcelicalderon merged 2 commits into
graphql-devise:masterfrom
artplan1:rails-7

Conversation

@artplan1

Copy link
Copy Markdown
Contributor

@mcelicalderon

mcelicalderon commented Dec 23, 2021

Copy link
Copy Markdown
Member

Thank you, @artplan1! I know bundle will fail for now until DTA merges and releases the linked PR, but you could already add the new appraisals to the circle CI matrix in https://github.com/graphql-devise/graphql_devise/blob/master/.circleci/config.yml and we can run the pipeline again afterwards.

I guess using the same exclusions and ruby version combinations we use for rails 6.2 6.1 should be fine.

@mcelicalderon
mcelicalderon merged commit 5ad11d5 into graphql-devise:master Jan 3, 2022
@mcelicalderon

Copy link
Copy Markdown
Member

Thank you @artplan1! Merging this one as is since lynndylanhurley/devise_token_auth#1517 was already merged. I will fix master in a separate commit and do some tweaks to the test matrix

@mcelicalderon mcelicalderon added the enhancement New feature or request label Jan 3, 2022
@artplan1
artplan1 deleted the rails-7 branch January 3, 2022 21:18
@mcelicalderon mcelicalderon removed the enhancement New feature or request label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants