Skip to content

xWebVirtualDirectory:Move localization data to psd file - #514

Closed
omiossec wants to merge 4 commits into
dsccommunity:devfrom
omiossec:devomiossec-MSFT_xWebVirtualDirectory
Closed

xWebVirtualDirectory:Move localization data to psd file#514
omiossec wants to merge 4 commits into
dsccommunity:devfrom
omiossec:devomiossec-MSFT_xWebVirtualDirectory

Conversation

@omiossec

@omiossec omiossec commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

Pull Request (PR) description

MSFT_xWebVirtualDirectory: Moving strings to localization file

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io

codecov-io commented Oct 4, 2019

Copy link
Copy Markdown

Codecov Report

Merging #514 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #514   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          17       17           
  Lines        2661     2661           
=======================================
  Hits         2432     2432           
  Misses        229      229
Impacted Files Coverage Δ
...WebVirtualDirectory/MSFT_xWebVirtualDirectory.psm1 89.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22802e7...08d00c9. Read the comment docs.

@johlju johlju added needs review The pull request needs a code review. duplicate The issue or PR is the duplicate of another. and removed needs review The pull request needs a code review. duplicate The issue or PR is the duplicate of another. labels Oct 4, 2019

@johlju johlju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tiny comments. Please make sure to update your other PR's similar.

Reviewed 2 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @omiossec)

a discussion (no related file):
Please update the CHANGELOG.md with an entry explaining this change.



DSCResources/MSFT_xWebVirtualDirectory/MSFT_xWebVirtualDirectory.psm1, line 53 at r2 (raw file):

$LocalizedData

Please update all references to $script:localizedData.

@johlju johlju added duplicate The issue or PR is the duplicate of another. invalid Used for PR's to tell hacktoberfest that the PR should not count and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Oct 6, 2019
@johlju

johlju commented Oct 6, 2019

Copy link
Copy Markdown
Member

This change has already been merged.

@johlju johlju closed this Oct 6, 2019
@johlju johlju changed the title MSFT_xWebVirtualDirectory:Move localization data to psd file xWebVirtualDirectory:Move localization data to psd file Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate The issue or PR is the duplicate of another. invalid Used for PR's to tell hacktoberfest that the PR should not count

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xWebVirtualDirectory: Move localization strings to strings.psd1 file

3 participants