Skip to content

xWebConfigKeyValue: Move localization strings to strings.psd1 file - #518

Merged
johlju merged 7 commits into
dsccommunity:devfrom
omiossec:devomiossec-MSFT_xWebConfigKeyValue
Oct 7, 2019
Merged

xWebConfigKeyValue: Move localization strings to strings.psd1 file#518
johlju merged 7 commits into
dsccommunity:devfrom
omiossec:devomiossec-MSFT_xWebConfigKeyValue

Conversation

@omiossec

@omiossec omiossec commented Oct 4, 2019 •
edited by johlju
Loading

Copy link
Copy Markdown
Contributor

Pull Request (PR) description

MSFT_xWebConfigKeyValue: Move localization strings to strings.psd1 file

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io

codecov-io commented Oct 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (dev@739fabd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #518   +/-   ##
======================================
  Coverage       ?   91.39%           
======================================
  Files          ?       17           
  Lines          ?     2661           
  Branches       ?        0           
======================================
  Hits           ?     2432           
  Misses         ?      229           
  Partials       ?        0
Impacted Files Coverage Δ
...FT_xWebConfigKeyValue/MSFT_xWebConfigKeyValue.psm1 92.85% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739fabd...11f1f78. Read the comment docs.

@omiossec

omiossec commented Oct 4, 2019

Copy link
Copy Markdown
Contributor Author

Fixe #472

@johlju johlju added the needs review The pull request needs a code review. label Oct 4, 2019
@johlju

johlju commented Oct 5, 2019

Copy link
Copy Markdown
Member

Please update this PR similar to #514.

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Oct 5, 2019
@omiossec

omiossec commented Oct 6, 2019

Copy link
Copy Markdown
Contributor Author

done

johlju
johlju approved these changes Oct 6, 2019
View reviewed changes

@johlju johlju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju changed the title MSFT_xWebConfigKeyValue: Move localization strings to strings.psd1 file xWebConfigKeyValue: Move localization strings to strings.psd1 file Oct 6, 2019
johlju
johlju approved these changes Oct 6, 2019
View reviewed changes

@johlju johlju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Oct 6, 2019
johlju
johlju requested changes Oct 6, 2019
View reviewed changes

@johlju johlju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @omiossec)

CHANGELOG.md, line 5 at r3 (raw file):

Changes to xWebAppPoolDefaults

This referencing the wrong resource name, should be xWebConfigKeyValue.

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. labels Oct 6, 2019
@omiossec

omiossec commented Oct 7, 2019

Copy link
Copy Markdown
Contributor Author

Ok change log modified

johlju
johlju approved these changes Oct 7, 2019
View reviewed changes

@johlju johlju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r6.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Oct 7, 2019
@johlju
johlju merged commit 7e1535d into dsccommunity:dev Oct 7, 2019
@johlju

johlju commented Oct 7, 2019

Copy link
Copy Markdown
Member

@omiossec Thank you for all the contributions! Much appreciated! 😃 🙇

@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Oct 7, 2019
gstorme pushed a commit to gstorme/xWebAdministration that referenced this pull request Feb 14, 2020
@omiossec Gregory Storme
xWebConfigKeyValue: Move localization strings to strings.psd1 file (d…
f5ef161 
…sccommunity#518)

- Changes to xWebConfigKeyValue
  - Move localization strings to strings.psd1 file (issue dsccommunity#472).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johlju johlju johlju approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

xWebConfigKeyValue: Move localization strings to strings.psd1 file

3 participants

@omiossec @codecov-io @johlju