xWebConfigProperty: Move localization strings to strings.psd1 file - #517
Merged
johlju merged 3 commits intoOct 6, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #517 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 17 17
Lines 2661 2661
=======================================
Hits 2432 2432
Misses 229 229
Continue to review full report at Codecov.
|
Contributor
Author
|
Fixe to #473 |
Member
|
Please update this PR similar to #514. |
johlju
added
waiting for code fix
johlju
approved these changes
Oct 6, 2019
johlju
left a comment
johlju
left a comment
Member
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
johlju
added
ready for merge
johlju
approved these changes
Oct 6, 2019
johlju
left a comment
johlju
left a comment
Member
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:
johlju
changed the title
johlju
removed
the
ready for merge
gstorme
pushed a commit
to gstorme/xWebAdministration
that referenced
this pull request
Feb 14, 2020
…sccommunity#517) - Changes to xWebConfigProperty - Move localization strings to strings.psd1 file (issue dsccommunity#473).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
xWebConfigProperty: Move localization strings to strings.psd1 file
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is