Integrate eslint with eslint-config-standard

[kaisalmen]

I have based this branch on your branch, because otherwise the changes are obsolete again soon and would need to be redone. Therefore the target branch is currently also use-monaco-vscode-api

@CGNonofr I used eslint-config-standard, but I made some adjustments:

• Indent is 4 instead of 2
• I favor semi-colons
• no-dupe-class-member is off
• no-redeclare, no-useless-constructor and no-void have been reduced to warn (you should check if the code should or could be changed or if eslint-disable should be set instead and we can then remove the rule reduction)

This closes #366

[CGNonofr]

Good job!

[CGNonofr]

Btw, you can use the header/header rule to ensure all files have the proper header

[kaisalmen]

I implemented the review comments and rebased the branch. Now, the build will fail because vscode-ws-jsonrpc will have lint related errors. I will fix this afternoon, I think.

[kaisalmen]

I have now enabled eslint globally for all packages and thanks for mentioning header/header. I have now integrated it.

[kaisalmen]

Build is green. Everything is in. If you agree with the latest changes this is good to go, I think.

[kaisalmen]

I will produce new dev releases once this is merged. Sounds good?

[CGNonofr]

I will produce new dev releases once this is merged. Sounds good?

Sounds good! What will we wait for before releasing a final version?

[CGNonofr]

LGTM

[kaisalmen]

Sounds good! What will we wait for before releasing a final version?

Actually a good question. We don't really have official beta tester. And a major version change should not immediately cripple correctly configured projects depending on here.

[CGNonofr]

It seems pretty safe to release a major version to me, and release fixes later, or we won't get any feedback

I'm already testing the new vscode-api approach for more than a week, and everything else is just refactors, it can't break things, can it?

[kaisalmen]

it can't break things, can it?

Let's go

[kaisalmen]

Done 🎉

https://www.npmjs.com/package/monaco-languageclient/v/2.0.0

https://www.npmjs.com/package/vscode-ws-jsonrpc/v/1.0.0

[CGNonofr]

Done tada

https://www.npmjs.com/package/monaco-languageclient/v/2.0.0

https://www.npmjs.com/package/vscode-ws-jsonrpc/v/1.0.0

Awesome! 🎉

[kaisalmen]

We should archive the repos of @codingame/monaco-jsonrpc and vscode-ws-jsonrpc and add links in the README that link to here.

[CGNonofr]

We should archive the repos of @codingame/monaco-jsonrpc and vscode-ws-jsonrpc and add links in the README that link to here.

Will do it on my side

[CGNonofr]

done!

[kaisalmen]

✅