Merge pull request #385 from TypeFox/eslint

Integrate eslint with eslint-config-standard

Author: kaisalmen

.eslintrc.js

@@ -0,0 +1,49 @@
+const path = require('path');
+const headerDef = path.resolve(__dirname, './packages/config/header.js');
+
+module.exports = {
+    env: {
+        browser: true,
+        es2020: true
+    },
+    extends: 'standard',
+    globals: {
+    },
+    parser: '@typescript-eslint/parser',
+    parserOptions: {
+        ecmaVersion: '2020',
+        sourceType: 'module',
+        project: './tsconfig.json'
+    },
+    plugins: [
+        '@typescript-eslint',
+        'import',
+        'unused-imports',
+        'header'
+    ],
+    rules: {
+        indent: ['error', 4, {
+            SwitchCase: 1
+        }],
+        semi: ['error', 'always'],
+        'no-extra-semi': 'off',
+        '@typescript-eslint/no-extra-semi': ['error'],
+        'no-dupe-class-members': 'off',
+        '@typescript-eslint/no-dupe-class-members': ['error'],
+        'no-redeclare': 'off',
+        '@typescript-eslint/no-redeclare': ['error'],
+        'no-useless-constructor': 'warn',
+        'no-void': 'warn',
+        // Following recommendation:
+        // https://typescript-eslint.io/docs/linting/troubleshooting/#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors
+        'no-undef': 'off',
+        'no-unused-vars': 'off',
+        '@typescript-eslint/no-unused-vars': ['warn', {
+            argsIgnorePattern: '^_'
+        }],
+        'header/header': [2, headerDef],
+        'dot-notation': 'off',
+        '@typescript-eslint/dot-notation': ['error']
+    },
+    ignorePatterns: ['.eslintrc.js', './packages/examples/browser-lsp/src/serverWorker.ts']
+};

.github/workflows/actions.yml

@@ -17,4 +17,6 @@ jobs:
     - name: Build
       shell: bash
       run: |
-        npm i && npm run build
+        npm ci
+        npm run build
+        npm run lint

.vscode/settings.json

@@ -4,10 +4,12 @@
   "editor.formatOnSave": false,
   "workbench.editor.revealIfOpen": true,
   "[javascript]": {
-    "editor.formatOnSave": true
+    "editor.formatOnSave": true,
+    "editor.defaultFormatter": "dbaeumer.vscode-eslint"
   },
   "[typescript]": {
-    "editor.formatOnSave": true
+    "editor.formatOnSave": true,
+    "editor.defaultFormatter": "dbaeumer.vscode-eslint"
   },
   "eslint.validate": [
     "javascript",