Specifically disable @typescript-eslint/dot-notation

Author: kaisalmen

.eslintrc.js

@@ -12,7 +12,8 @@ module.exports = {
     parser: '@typescript-eslint/parser',
     parserOptions: {
         ecmaVersion: '2020',
-        sourceType: 'module'
+        sourceType: 'module',
+        project: './tsconfig.json'
     },
     plugins: [
         '@typescript-eslint',
@@ -40,7 +41,9 @@ module.exports = {
         '@typescript-eslint/no-unused-vars': ['warn', {
             argsIgnorePattern: '^_'
         }],
-        'header/header': [2, headerDef]
+        'header/header': [2, headerDef],
+        'dot-notation': 'off',
+        '@typescript-eslint/dot-notation': ['error']
     },
     ignorePatterns: ['.eslintrc.js', './packages/examples/browser-lsp/src/serverWorker.ts']
 };

packages/client/src/disposable.ts

@@ -10,7 +10,7 @@ export class DisposableCollection implements Disposable {
 
     dispose (): void {
         while (this.disposables.length !== 0) {
-            this.disposables.pop()?.dispose();
+            this.disposables.pop()!.dispose();
         }
     }
 

packages/client/src/monaco-language-client.ts

@@ -3,8 +3,6 @@
  * Licensed under the MIT License. See License.txt in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
 
-/* eslint-disable dot-notation */
-
 import {
     BaseLanguageClient, MessageTransports, LanguageClientOptions, CloseAction, ErrorAction
 } from 'vscode-languageclient/lib/common/client';
@@ -54,14 +52,18 @@ export class MonacoLanguageClient extends BaseLanguageClient {
 
         // Hack because vscode-language client rejects the whole registration block if one capability registration has no associated client feature registered
         // Some language servers still send the registration even though the client says it doesn't support it
+        // eslint-disable-next-line @typescript-eslint/dot-notation
         const originalHandleRegistrationRequest: (params: RegistrationParams) => Promise<void> = this['handleRegistrationRequest'].bind(this);
+        // eslint-disable-next-line @typescript-eslint/dot-notation
         this['handleRegistrationRequest'] = (params: RegistrationParams) => {
             originalHandleRegistrationRequest({
                 ...params,
                 registrations: params.registrations.filter(registration => this.getFeature(<any>registration.method) != null)
             });
         };
+        // eslint-disable-next-line @typescript-eslint/dot-notation
         const originalHandleUnregistrationRequest: (params: UnregistrationParams) => Promise<void> = this['handleUnregistrationRequest'].bind(this);
+        // eslint-disable-next-line @typescript-eslint/dot-notation
         this['handleUnregistrationRequest'] = (params: UnregistrationParams) => {
             originalHandleUnregistrationRequest({
                 ...params,
@@ -79,8 +81,10 @@ export class MonacoLanguageClient extends BaseLanguageClient {
     }
 
     protected override registerBuiltinFeatures () {
+        // eslint-disable-next-line @typescript-eslint/dot-notation
         this.registerFeature(new DidOpenTextDocumentFeature(this, this['_syncedDocuments']));
         this.registerFeature(new DidChangeTextDocumentFeature(this));
+        // eslint-disable-next-line @typescript-eslint/dot-notation
         this.registerFeature(new DidCloseTextDocumentFeature(this, this['_syncedDocuments']));
         this.registerFeature(new CompletionItemFeature(this));
         this.registerFeature(new HoverFeature(this));