Create Graphics Settings Presets [SYNTH-91] - #1325
Conversation
Added dropdown menu to select graphics Created low, high, and ultra settings Sliders now respond to changes not made by them
RoushilS
added
rendering
rutmanz
left a comment
rutmanz
left a comment
There was a problem hiding this comment.
I think it's a little unintuitive to have the label stay when you manually change settings off of the preset, maybe change it to say "custom" or just be blank when other settings are modified. This also has the odd consequence of any modified graphics settings showing up as "medium" when you reload.
| return { | ||
| lightIntensity: 3, | ||
| fancyShadows: false, | ||
| maxFar: 20, | ||
| cascades: 2, | ||
| shadowMapSize: 2048, | ||
| antiAliasing: false, | ||
| } |
There was a problem hiding this comment.
I could be wrong but I'm pretty sure light intensity doesn't change performance, it's just like a brightness setting. And (assuming the UI is done correctly) the shadow-related properties are ignored when fancy shadows are off, making low graphics just like medium graphics performance-wise but darker. Maybe remove low and shift the other ones so medium is low, high is medium (default), etc?
There was a problem hiding this comment.
Also another note, there are differences in maxFar, cascades, shadowMapSize - all of which actually do not make a difference when fancyShadows is set to false. So, there is pretty much no quality difference between the two
| return { | ||
| lightIntensity: 3, | ||
| fancyShadows: false, | ||
| maxFar: 20, | ||
| cascades: 2, | ||
| shadowMapSize: 2048, | ||
| antiAliasing: false, | ||
| } |
There was a problem hiding this comment.
Also another note, there are differences in maxFar, cascades, shadowMapSize - all of which actually do not make a difference when fancyShadows is set to false. So, there is pretty much no quality difference between the two
|
Because of my newfound knowledge, and the reviews, I pushed some changes and tested everything again. I think I found and patched all of the bugs but there could be more. |
|
might be good to wait for #1323 so that the |
AlexD717
left a comment
AlexD717
left a comment
There was a problem hiding this comment.
lgtm. I like how the light intensity doesn't affect graphics settings.
5 participants
TASK
SYNTH-91
Symptom
If the user wants to configure the simulation quality and performance to be optimized on their device, they have no quick way to do so.
Solution
Test various performance settings at 5 levels. Create a dropdown UI that allows clean preset selection. Also implement save and cancel behavior. Add useEffect to StatefulSlider to automatically update when base variable changes, as there was previously a disconnect when a user selected the preset but it didn't update. Add reusable setGraphicsPreferences method to make code more concise.
Additionally, reviewers ensuring that these actually are the best graphics presets for the simulator would be very much appreciated.
Verification
Before merging, ensure the following criteria are met: