-
Notifications
You must be signed in to change notification settings - Fork 62
Create Graphics Settings Presets [SYNTH-91]
#1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bd54086
feat: add custom graphics preset menu
RoushilS 1376f5a
feat: add cancellation and save functionality
RoushilS a7ddc8b
fix: format
RoushilS ea6a2da
fix: remove unused import
RoushilS 46d9d5f
fix: rework preferences
RoushilS d639fc3
fix: style
RoushilS b74fd4e
fix: rename functions
RoushilS 9e2612e
fix: style
RoushilS 6c5effd
Merge branch 'dev' into roushils/91/graphics-setting-presets
RoushilS b79e101
Merge branch 'dev' into roushils/91/graphics-setting-presets
PepperLola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong but I'm pretty sure light intensity doesn't change performance, it's just like a brightness setting. And (assuming the UI is done correctly) the shadow-related properties are ignored when fancy shadows are off, making low graphics just like medium graphics performance-wise but darker. Maybe remove low and shift the other ones so medium is low, high is medium (default), etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also another note, there are differences in maxFar, cascades, shadowMapSize - all of which actually do not make a difference when fancyShadows is set to false. So, there is pretty much no quality difference between the two