HAL_ChibiOS: raise SDMMC clock limit on H7 - #26090
Merged
Merged
Conversation
this allows for faster log download on ethernet
andyp1per
approved these changes
Jan 28, 2024
Contributor
|
I have a feeling we'll need a way to slow it down if we detect write errors. |
Contributor
Author
we do have the parameter BRD_SD_SLOWDOWN already |
Contributor
|
This has led to the JFB110 board becoming unresponsive and even setting BRD_SD_SLOWDOWN to 10 doesn't seem to help |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR raises the SDMMC clock limit on the H7 board from 12.5MHz to 50MHz to enable faster log downloads via ethernet. Key changes include:
- Updating the SDMMC clock maximum setting in the hardware configuration header.
- Removing the older reliability comment in favor of the higher clock speed setting.
Comments suppressed due to low confidence (1)
libraries/AP_HAL_ChibiOS/hwdef/common/stm32h7_mcuconf.h:636
- [nitpick] Consider adding a brief note on the reliability tests conducted or recommended precautions for the increased 50MHz clock rate, since the previous comment mentioning reliability has been removed.
// limit SDMMC clock to 50MHz by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows for faster log download on ethernet.
On CubeRedPrimary log download using the web server on ethernet goes up from 2.4MByte/s to 4.0MByte/s
I don't think this should go straight into 4.5.x, I'd like to see if anyone notices any reliability issues with the faster clock first