Improvements to patch testing#326
Merged
cconlon merged 1 commit intowolfSSL:masterfrom Feb 9, 2026
Merged
Conversation
padelsbach
force-pushed
the
all-patched-target-updates
branch
6 times, most recently
from
245a5cd to
9cf3514
Compare
padelsbach
commented
Feb 6, 2026
There was a problem hiding this comment.
Pull request overview
This PR improves the patch testing infrastructure for wolfSSL JNI by enhancing how PR patches are discovered, validated, and applied during CI builds. The changes ensure that all PR patches (not just the highest numbered one) are properly checked, and introduces a cleaner flag-based approach for applying patches during builds.
Changes:
- Added a helper script to query GitHub API for PR fork/branch information and status
- Modified the CI workflow to check all PR patches (not just the highest numbered) and validate their states
- Replaced the dedicated
all-patchedMakefile target with a flag-based approach usingENABLE_PATCHES=1 - Updated CMakeLists.txt to exclude additional wolfSSL source files that are included inline
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| scripts/find-pr-fork-branch.sh | New helper script that queries GitHub API to get PR fork/branch and status information |
| Makefile | Replaces all-patched target with conditional logic using ENABLE_PATCHES=1 flag to apply patch defines |
| IDE/Android/app/src/main/cpp/CMakeLists.txt | Adds additional wolfSSL source files to exclusion list (files that are included inline by others) |
| .github/workflows/jni-patched-ci.yml | Enhanced to check all PR patches instead of just the highest numbered one, with logic to handle multiple PRs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@padelsbach please give the Copilot items above a look and see which of those you want to fix/implement, thanks. |
padelsbach
force-pushed
the
all-patched-target-updates
branch
from
9cf3514 to
a8fa221
Compare
Closed
padelsbach
force-pushed
the
all-patched-target-updates
branch
from
a8fa221 to
dfba100
Compare
This was referenced Feb 7, 2026
cconlon
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jni-patched-ci.yml, check that all PR patches have been applied, not just the highest numberedENABLE_PATCHES=1to apply patches rather the dedicated target