Update line length check#328
Merged
cconlon merged 1 commit intowolfSSL:masterfrom Feb 10, 2026
Merged
Conversation
padelsbach
force-pushed
the
line-length-check-updates
branch
5 times, most recently
from
e832370 to
31f1957
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the CI line-length check to use a reusable helper script, aiming to correct incorrect line numbers reported in workflow output and enabling local execution (e.g., via git hooks).
Changes:
- Added
scripts/line-length-check-added-lines.shto detect >80-char lines introduced by a PR diff while ignoring pre-existing long lines. - Simplified the GitHub Actions workflow to call the helper script instead of embedding the check logic inline.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
scripts/line-length-check-added-lines.sh |
New helper script implementing the “check only added lines” line-length enforcement logic. |
.github/workflows/line-length-check.yml |
Replaces inline bash logic with a call to the new helper script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
padelsbach
force-pushed
the
line-length-check-updates
branch
from
31f1957 to
bd53f9a
Compare
padelsbach
force-pushed
the
line-length-check-updates
branch
from
bd53f9a to
12cc449
Compare
cconlon
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commitorpre-pushstep)Android CI failures are fixed with #326. Please merge that first.