Add CRL generation capability#315
Merged
cconlon merged 3 commits intowolfSSL:masterfrom Feb 16, 2026
Merged
Conversation
padelsbach
force-pushed
the
crl-generation
branch
from
d84fe0d to
8e8480d
Compare
padelsbach
force-pushed
the
crl-generation
branch
5 times, most recently
from
a016758 to
3676f25
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 15 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
padelsbach
force-pushed
the
crl-generation
branch
7 times, most recently
from
8b9532c to
8af03a8
Compare
Contributor
Author
|
The FIPS failures are due to the use of the main wolfSSL repo and are expected to be fixed once the CRL PR is merged on the wolfSSL repo. I will also revert the yamls at that point. |
cconlon
requested changes
Jan 23, 2026
padelsbach
force-pushed
the
crl-generation
branch
4 times, most recently
from
e3c6435 to
dbfe657
Compare
padelsbach
force-pushed
the
crl-generation
branch
from
59d9989 to
42c47d6
Compare
padelsbach
force-pushed
the
crl-generation
branch
from
42c47d6 to
67d1fb0
Compare
Closed
padelsbach
force-pushed
the
crl-generation
branch
3 times, most recently
from
56fa7d0 to
cd84fac
Compare
cconlon
requested changes
Feb 10, 2026
padelsbach
force-pushed
the
crl-generation
branch
from
cd84fac to
06803f3
Compare
padelsbach
force-pushed
the
crl-generation
branch
from
06803f3 to
ee502c4
Compare
padelsbach
force-pushed
the
crl-generation
branch
from
ee502c4 to
ccbdc9f
Compare
cconlon
requested changes
Feb 11, 2026
Member
cconlon
left a comment
cconlon
left a comment
There was a problem hiding this comment.
Just one more small request on this one. Would you mind adding WolfSSLCRL.java to our scripts/infer.sh static analysis script? Something like this should work. I already verified it doesn't catch any issues, but is good to have for future work.
diff --git a/scripts/infer.sh b/scripts/infer.sh
index e9dd7a9..6c6c92d 100755
--- a/scripts/infer.sh
+++ b/scripts/infer.sh
@@ -38,6 +38,7 @@ infer --fail-on-issue run -- javac \
src/java/com/wolfssl/WolfSSLAltName.java \
src/java/com/wolfssl/WolfSSLByteBufferIORecvCallback.java \
src/java/com/wolfssl/WolfSSLByteBufferIOSendCallback.java \
+ src/java/com/wolfssl/WolfSSLCRL.java \
src/java/com/wolfssl/WolfSSLCertManager.java \
src/java/com/wolfssl/WolfSSLCertRequest.java \
src/java/com/wolfssl/WolfSSLCertificate.java \
ccbdc9f to
873ed6c
Compare
Member
|
Thanks, this looks good to me. I'll approve/merge once wolfSSL/wolfssl#9631 gets merged in. |
cconlon
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add wrappers for CRL generation logic. Requires wolfSSL/wolfssl#9631 to be merged.
Android and JNI CI failures are fixed with #326. Please merge that first.