fix: unhandle error when parameter is not set in v3 and v5 - #618
Closed
rzkytmgr wants to merge 0 commit into
Closed
Conversation
broofa
reviewed
Mar 8, 2022
Author
of course with pleasure, let me work for it. |
broofa
approved these changes
Mar 8, 2022
Member
Member
|
@ctavan ping |
Member
|
Proposed an alternative fix to the CI issue in #621. I'd prefer to merge that one first to produce a cleaner diff in this PR. |
Member
|
I think I somehow messed this up while rebasing… I created #622 with the same patch instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
source only checks if
namespacetype is equal tostring. The error will be triggered when thenamespacetype is not equal tostringunless thenamespaceparameter presented as an array.Thank you,