node@16.14 import assertions break examples/node-esmodules/example.mjs test

[broofa]

@ctavan:

• module: Unflag JSON modules nodejs/node#41736 has landed, causing our 16.x CI test to break.
• There's a simple fix, but this won't build on older node versions due to the unexpected syntax.
• My temporary fix for fix: unhandle error when parameter is not set in v3 and v5 #618 is to lock our CI test to node@16.13, but that's just a band-aid. We should be testing on the latest major version across the board.
• An alternative is to just remove that import and not use it. But it might be testing an important feature, so I'm hesitant to do that.

Care to comment (or, better, fix)?

[ctavan]

First of all it took me a while to realize that the unflagging of --experimental-json-modules (nodejs/node#41736) has in fact not yet made it to the 16.x line of Node.js.

The problematic piece seems to be the import assertions that were added in 16.14.0.

In any case, the best thing I could come up with was extracting the package.json edge case into a separate test that is only run on node 16.x.

I would like to keep coverage of this edge case as it was a real world problem that we once fixed. At the same time I would like to keep esm tests running on Node.js 14 which also have stable support for them.