Skip to content

fix: synchronize patching binding/createWriteStream/cwd/chdir - #307

Merged
tschaub merged 1 commit into
masterfrom
simplify
Aug 20, 2020
Merged

fix: synchronize patching binding/createWriteStream/cwd/chdir#307
tschaub merged 1 commit into
masterfrom
simplify

Conversation

@3cp

@3cp 3cp commented Aug 13, 2020

Copy link
Copy Markdown
Collaborator

All the patches now check same realBinding._mockedBinding. This should
fix the edge cases around the new feature bypass().

follows up #306

@3cp
3cp requested a review from tschaub August 13, 2020 23:41
Comment thread lib/index.js Outdated
All the patches now check same realBinding._mockedBinding. This should
fix the edge cases around the new feature bypass().

follows up #306

@tschaub tschaub left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @3cp. Thanks for tightening this up.

@3cp

3cp commented Aug 18, 2020

Copy link
Copy Markdown
Collaborator Author

Can we have a release?

@tschaub
tschaub merged commit b72e21b into master Aug 20, 2020
@tschaub
tschaub deleted the simplify branch August 20, 2020 22:41
@tschaub

tschaub commented Aug 20, 2020

Copy link
Copy Markdown
Owner

Published with mock-fs@4.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants