Bypass updates - #306
Merged
Merged
Conversation
Collaborator
|
Instead of playing _mockedBinding, it's probably cheaper and less code if we use a boolean flag on realBinding to temporarily disable mocking. |
Owner
Author
|
It looks like there will be more to do to get |
Collaborator
|
The patches for cwd/chdir/createWriteStream/binding should all check the same _mockedBinding (or a flag) on realBinding. This also means we only need to patch them once without real restore. The restore (not just for bypass) only needs to remove _mockedBinding (and the flag). I will create a draft. |
Collaborator
|
Could you merge #303 first? |
3cp
added a commit
that referenced
this pull request
Aug 13, 2020
All the patches now check same realBinding._mockedBinding. This should fix the edge cases around the new feature bypass(). follows up #306
3cp
added a commit
that referenced
this pull request
Aug 15, 2020
All the patches now check same realBinding._mockedBinding. This should fix the edge cases around the new feature bypass(). follows up #306
3cp
added a commit
that referenced
this pull request
Aug 15, 2020
All the patches now check same realBinding._mockedBinding. This should fix the edge cases around the new feature bypass(). follows up #306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #304.