Skip to content

test(money): cover converter throw narrowing#32

Merged
simPod merged 4 commits into
masterfrom
test/currency-converter-known-currency
Jun 22, 2026
Merged

test(money): cover converter throw narrowing#32
simPod merged 4 commits into
masterfrom
test/currency-converter-known-currency

Conversation

@simPod

@simPod simPod commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Summary

Adds focused CurrencyConverter throw-type assertions for convert():

  • known currencies remove UnknownCurrencyException while residual exchange-rate and rounding exceptions are handled
  • named safe rounding modes remove RoundingNecessaryException while residual exchange-rate and unknown-currency exceptions are handled

This PR changes tests only.

@simPod simPod changed the title test(money): cover converter throw narrowing test(money): cover converter narrowing across brick versions Jun 22, 2026
@simPod simPod force-pushed the test/currency-converter-known-currency branch from 9828c84 to aca67bb Compare June 22, 2026 05:39
@simPod simPod changed the title test(money): cover converter narrowing across brick versions test(money): cover converter throw narrowing Jun 22, 2026
@simPod simPod force-pushed the test/currency-converter-known-currency branch from aca67bb to d33d3b1 Compare June 22, 2026 05:47
@simPod simPod merged commit 05b3d9e into master Jun 22, 2026
15 of 17 checks passed
@simPod simPod deleted the test/currency-converter-known-currency branch June 22, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant