fix(money): handle converter rounding mode index#31
Merged
Conversation
simPod
changed the title
simPod
force-pushed
the
fix/currency-converter-rounding-mode
branch
from
df458ba to
b92520f
Compare
simPod
changed the title
simPod
force-pushed
the
fix/currency-converter-rounding-mode
branch
from
1ba4c29 to
5f3257e
Compare
simPod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CurrencyConverter throw type narrowing for brick/money ^0.13 by checking convert()'s roundingMode argument at index 4.
Keeps the package requirement at brick/money ^0.13 only.
Removes the obsolete pre-0.13 positional converter test case that used the old convert(context, roundingMode) shape.