fix(drawer): addressed issue with inline/static and glass bgs

[mcoker]

fixes #8340

Summary by CodeRabbit

• Style
  • Inline drawer panels now use a floating default background at smaller sizes, with a medium+ breakpoint restoring the primary background for consistent visuals.
  • Glass effect rules for inline/static drawers are limited to medium+ breakpoints and refined for better theme scoping and visual cohesion.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 53b03e18-d5f1-48f4-b2a5-e135b9492af8

📥 Commits

Reviewing files that changed from the base of the PR and between cceff04 and dca8504.

📒 Files selected for processing (1)

• src/patternfly/components/Drawer/drawer.scss

🚧 Files skipped from review as they are similar to previous changes (1)

• src/patternfly/components/Drawer/drawer.scss

---

Walkthrough

This PR changes inline drawer panel default background from primary to floating, adds an md breakpoint override to use primary background at medium widths, and moves inline/static glass styling into the min-width: md responsive block with theme-scoped selectors and backdrop-filter rules.

Changes

Drawer Panel Theming and Glass Styling

Layer / File(s)	Summary
Inline panel background tokens src/patternfly/components/Drawer/drawer.scss	Default --panel--m-inline--BackgroundColor switches from primary to floating background; --panel--m-inline--md--BackgroundColor override uses primary background at md breakpoint.
Glass styling restructure src/patternfly/components/Drawer/drawer.scss	Removed base .pf-m-inline, .pf-m-static .pf-m-glass block; added min-width: md scoped .pf-m-glass rules under theme-scoped selector to set glass background/border variables and backdrop-filter; plain panels handle transparency under the theme scope.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• patternfly/patternfly#8318: Updates Drawer SCSS glass/transparent selector logic overlapping with this PR.
• patternfly/patternfly#8307: Refactors .pf-m-glass/backdrop-filter styling to be theme-scoped in other components.
• patternfly/patternfly#8096: Modifies Drawer SCSS to adjust background and glass token usage.

Suggested labels

released on @prerelease``

Suggested reviewers

• thatblindgeye
• jcmill

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title follows conventional commit format with 'fix' prefix and includes the component scope, but uses unclear abbreviation 'bgs' instead of the full word 'backgrounds'.
Linked Issues check	✅ Passed	The PR addresses the main glass styling validation objective from issue #8340 by reworking glass styling for inline/static drawers and adjusting background tokens as required.
Out of Scope Changes check	✅ Passed	All changes are within scope—the drawer.scss modifications directly address the glass style validation and background token issues specified in issue #8340 without introducing unrelated changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[patternfly-build]

Preview: https://pf-pr-8397.surge.sh

A11y report: https://pf-pr-8397-a11y.surge.sh

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/patternfly/components/Drawer/drawer.scss (1)

959-961: 💤 Low value

Remove commented-out code.

This commented-out empty selector adds no value and should be removed to keep the codebase clean. If this is intended for future use, add a TODO comment explaining the purpose.

♻️ Proposed cleanup

-// :where(.pf-v6-theme-glass) {
-  
-// }
-

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/patternfly/components/Drawer/drawer.scss` around lines 959 - 961, Remove
the commented-out empty selector block in drawer.scss (the commented lines
containing :where(.pf-v6-theme-glass)), as it adds no value; delete the
commented code or, if it's intentionally reserved for future work, replace it
with a single-line TODO comment explaining the intended purpose and referencing
.pf-v6-theme-glass so the intent is explicit.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/patternfly/components/Drawer/drawer.scss`:
- Line 666: The selector `@at-root :where(:root(.pf-v6-theme-glass))
&.pf-m-glass` is invalid because `:root()` functional syntax is not allowed;
replace that pattern with the correct selector used elsewhere:
`:root.pf-v6-theme-glass` so the rule targeting `.pf-m-glass` inside the Drawer
glass theme is parsed correctly; update the `@at-root` line and keep the rest of
the rule intact so glass styling for inline/static drawer panels at md+ applies.

---

Nitpick comments:
In `@src/patternfly/components/Drawer/drawer.scss`:
- Around line 959-961: Remove the commented-out empty selector block in
drawer.scss (the commented lines containing :where(.pf-v6-theme-glass)), as it
adds no value; delete the commented code or, if it's intentionally reserved for
future work, replace it with a single-line TODO comment explaining the intended
purpose and referencing .pf-v6-theme-glass so the intent is explicit.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1499991e-4ad7-4256-9650-ebc01c5b93d9

📥 Commits

Reviewing files that changed from the base of the PR and between e2ca06a and ee448f8.

📒 Files selected for processing (1)

• src/patternfly/components/Drawer/drawer.scss

[jcmill]

🧹

[patternfly-build]

🎉 This PR is included in version 6.5.0-prerelease.91 🎉

The release is available on:

• GitHub release
• npm package (@prerelease dist-tag)

Your semantic-release bot 📦🚀