Skip to content

feat(drawer): add plain variant to section#8318

Merged
thatblindgeye merged 2 commits into
patternfly:mainfrom
mcoker:issue-8317
Apr 16, 2026
Merged

feat(drawer): add plain variant to section#8318
thatblindgeye merged 2 commits into
patternfly:mainfrom
mcoker:issue-8317

Conversation

@mcoker
Copy link
Copy Markdown
Contributor

@mcoker mcoker commented Apr 16, 2026

fixes #8317

Summary by CodeRabbit

  • Style

    • Drawer section header plain styling now renders a transparent background consistently with other background modifiers.
  • Documentation

    • Updated Drawer docs to reflect that the plain modifier applies to section elements and how the no-plain-on-glass exception behaves.

@mcoker mcoker requested review from kmcfaul and tlabaj April 16, 2026 15:44
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4606bde2-da61-40af-a6af-24591b036042

📥 Commits

Reviewing files that changed from the base of the PR and between c6fafdd and 2b0d655.

📒 Files selected for processing (2)
  • src/patternfly/components/Drawer/drawer.scss
  • src/patternfly/components/Drawer/examples/Drawer.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/patternfly/components/Drawer/drawer.scss

Walkthrough

Apply .pf-m-plain to Drawer section background rules so the section header background can be transparent under the same glass/root conditions previously gating .pf-m-no-background. Update example docs to document .pf-m-plain and .pf-m-no-plain-on-glass affecting the section element.

Changes

Cohort / File(s) Summary
Drawer Section Styling
src/patternfly/components/Drawer/drawer.scss
Add .pf-m-plain (and .pf-m-plain with .pf-m-no-plain-on-glass exceptions) to the selector that sets --pf-c-drawer__section--BackgroundColor: transparent, grouping it with the existing .pf-m-no-background case.
Drawer Documentation
src/patternfly/components/Drawer/examples/Drawer.md
Update documentation examples to indicate .pf-m-plain and .pf-m-no-plain-on-glass also apply to the .pf-v6-c-drawer__section element (in addition to panel selectors).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

  • #8317: Drawer - add plain modifier to drawer section — PR implements adding .pf-m-plain to the drawer section as requested.
  • Drawer - Glass style follow up patternfly-react#12273: Matches discussion on .pf-m-plain, .pf-m-no-plain-on-glass, and transparent background behavior for Drawer sections.

Possibly related PRs

Suggested labels

released on @prerelease``

Suggested reviewers

  • thatblindgeye
  • jcmill
  • srambach
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title follows conventional commit format with 'feat' type and clear scope, accurately describing the main change of adding a plain variant to the drawer section.
Linked Issues check ✅ Passed The code changes successfully implement the primary objective from issue #8317 by adding the .pf-m-plain modifier to drawer section styling and documentation.
Out of Scope Changes check ✅ Passed All changes directly relate to the linked issue objective. Both SCSS and documentation modifications focus on implementing plain variant support for drawer sections.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Apr 16, 2026

@mcoker mcoker requested a review from thatblindgeye April 16, 2026 17:53
@thatblindgeye thatblindgeye merged commit 629b06d into patternfly:main Apr 16, 2026
5 checks passed
@patternfly-build
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.71 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drawer - add plain modifier to drawer section

5 participants