Skip to content

Make POIs on unnamed streets searchable by address #4168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pawank925 wants to merge 1 commit into from
+45 −0
Closed

Make POIs on unnamed streets searchable by address #4168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions lib-sql/functions/placex_triggers.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@ DECLARE

addr_item RECORD;
addr_place RECORD;
parent_place RECORD;
parent_address_place_ids BIGINT[];
BEGIN
nameaddress_vector := '{}'::INTEGER[];
Expand All @@ -418,6 +419,24 @@ BEGIN
FROM search_name s
WHERE s.place_id = parent_place_id;

IF parent_address_vector is null
AND (token_get_name_search_tokens(token_info) is not null
OR token_get_housenumber_search_tokens(token_info) is not null)
THEN
parent_name_vector := '{}'::INTEGER[];
parent_address_vector := '{}'::INTEGER[];

FOR parent_place IN
SELECT s.name_vector
FROM place_addressline pa
JOIN search_name s ON s.place_id = pa.address_place_id
WHERE pa.place_id = parent_place_id
LOOP
parent_address_vector := array_merge(parent_address_vector,
parent_place.name_vector);
END LOOP;
END IF;

FOR addr_item IN
SELECT ranks.*, key,
token_get_address_search_tokens(token_info, key) as search_tokens
Expand Down
26 changes: 26 additions & 0 deletions test/bdd/features/db/import/search_name.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,32 @@ Feature: Creation of search terms
| object |
| N1 |

Scenario: Named POIs on unnamed streets can be found by address
Given the grid
| 100 | | | | | 101 |
| | | 1 | | | |
| 103 | 10 | | | 11 | 102 |
And the places
| osm | class | type | name | housenr |
| N1 | place | house | Blue house | 23 |
And the places
| osm | class | type | name+name | geometry |
| R1 | place | city | Strange Town | (100,101,102,103,100) |
And the places
| osm | class | type | geometry |
| W1 | highway | residential | 10,1,11 |
And the ways
| id | nodes |
| 1 | 10,1,11 |
When importing
Then placex contains
| object | parent_place_id |
| N1 | W1 |
When geocoding "Blue house, Strange Town"
Then the result set contains
| object |
| N1 |

Scenario: Some addr: tags are added to address
Given the grid
| | 2 | 3 | |
Expand Down