Make POIs on unnamed streets searchable by address - #4168
Closed
pawank925 wants to merge 1 commit into
Closed
Conversation
pawank925
force-pushed
the
master
branch
4 times, most recently
from
August 16, 2026 18:00
6ceddc1 to
df7048b
Compare
When a POI is parented to an unnamed street, the street has no entry in the search_name table. The POI then gets no address terms at all and can only be found by its name. Use the address objects of the parent from place_addressline to fill in the missing address terms.
Author
|
branch was wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4133
POIs that are parented to an unnamed street do not inherit any address terms because the parent street has no entry in the search_name table. The nameaddress_vector in the search_name table stays empty and the POI can only be found by its own name.
When the parent has no search terms, look up the address objects of the parent in place_addressline, take their name_vector entries from search_name and merge them into the address terms of the POI.
Adds a BDD test that verifies a named POI on an unnamed street inside a city is found when searching for the name together with the city.