Support both JSON schema validator target names - #541
Open
wolfv wants to merge 1 commit into
Open
Conversation
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different releases of
nlohmann_json_schema_validatorexport different CMake target names. The version pinned bynlohmann_json_schema_validator_vendorexports the unnamespacednlohmann_json_schema_validatortarget, while newer releases providenlohmann_json_schema_validator::validator.Select the target that is actually available in both
rmf_websocketandrmf_task_ros2. This fixes clean builds against the currently vendored validator without dropping compatibility with newer validator packages.The unnamespaced target is checked first because
rmf_task_ros2may see an unresolved namespaced target reference transitively fromrmf_websocket.Signed-off-by: Wolf Vollprecht w.vollprecht@gmail.com