Skip to content

doc: (http2) update push and trailers event with rawHeaders param#63259

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
samuel871211:pushAndTrailers
May 19, 2026
Merged

doc: (http2) update push and trailers event with rawHeaders param#63259
aduh95 merged 1 commit into
nodejs:mainfrom
samuel871211:pushAndTrailers

Conversation

@samuel871211
Copy link
Copy Markdown
Contributor

@samuel871211 samuel871211 commented May 12, 2026 •
edited
Loading

https://github.com/nodejs/node/blob/main/lib/internal/http2/core.js#L357

function onSessionHeaders
    if (reqAsync)
      reqAsync.runInAsyncScope(process.nextTick, null, emit, stream, event, obj, flags, headers);
    else
      process.nextTick(emit, stream, event, obj, flags, headers);

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 12, 2026

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels May 12, 2026
@samuel871211 samuel871211 force-pushed the pushAndTrailers branch 3 times, most recently from c1bb7b4 to a76836b Compare May 12, 2026 01:16
pimterry
pimterry approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks for spotting & fixing this! 👍

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 13, 2026

Can you please change the subsystem from http2: to doc: please?

@samuel871211 samuel871211 changed the title doc[http2]: update push and trailers event with rawHeaders param doc: (http2) update push and trailers event with rawHeaders param May 13, 2026
@lpinca
Copy link
Copy Markdown
Member

lpinca commented May 13, 2026

Can you please change the subsystem from http2: to doc: please?

@samuel871211, I'm pretty sure @aduh95 was referring to the commit message, not PR title.

@samuel871211
doc: (http2) update push and trailers event with rawHeaders param
7c82b59 
Signed-off-by: Yu-Sheng Chen <samuel871211@gmail.com>
Ethan-Arrowood
Ethan-Arrowood reviewed May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to run linter/formatter. I think the line 1711 needs to be wrapped.

@samuel871211
Copy link
Copy Markdown
Contributor Author

samuel871211 commented May 16, 2026

make sure to run linter/formatter. I think the line 1711 needs to be wrapped.

Done with node ./tools/lint-md/lint-md.mjs --format doc/api/http2.md — no changes were made by the formatter.

Also per doc/README.md:

Wrap documents at 120 characters per line

Line 1711 is 93 characters, well within the limit.

Happy to be corrected if I'm missing something.

@aduh95 aduh95 merged commit 5605f6b into nodejs:main May 19, 2026
15 checks passed
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 19, 2026

Landed in 5605f6b

aduh95 pushed a commit that referenced this pull request May 20, 2026
@samuel871211 @aduh95
doc: update http2's push and trailers events with rawHeaders param
c31f320 
Signed-off-by: Yu-Sheng Chen <samuel871211@gmail.com>
PR-URL: #63259
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@pimterry pimterry pimterry approved these changes

@Ethan-Arrowood Ethan-Arrowood Awaiting requested review from Ethan-Arrowood

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@samuel871211 @nodejs-github-bot @aduh95 @lpinca @pimterry @Ethan-Arrowood