test: update WPT for wasm/jsapi to 288c467d35#63136
Open
nodejs-github-bot wants to merge 3 commits intomainfrom
Open
test: update WPT for wasm/jsapi to 288c467d35#63136nodejs-github-bot wants to merge 3 commits intomainfrom
nodejs-github-bot wants to merge 3 commits intomainfrom
Conversation
Collaborator
Author
|
Review requested:
|
This was referenced May 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63136 +/- ##
==========================================
+ Coverage 89.67% 90.04% +0.36%
==========================================
Files 712 713 +1
Lines 221251 224926 +3675
Branches 42393 42521 +128
==========================================
+ Hits 198413 202526 +4113
+ Misses 14681 14195 -486
- Partials 8157 8205 +48 🚀 New features to boost your workflow:
|
Original commit message:
[wasm] Update WebAssembly.Exception JS API
WebIDL specifies the existence of a
`WebAssembly.Exception.prototype.stack` getter.
WebIDL also expects the constructor to have 2 parameters (plus an
optional one).
https://webassembly.github.io/spec/js-api/#exceptions
Bug: 336347912, 42204334
Change-Id: I128e976a84f942dcf9b93a157534b15fad0f9215
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7697976
Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
Auto-Submit: Matthias Liedtke <mliedtke@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106215}
Refs: v8/v8@435a2cd
targos
force-pushed
the
actions/update-wasm/jsapi-wpt
branch
from
3e9d8f0 to
7a69c6c
Compare
Member
|
I added a cherry-pick of the V8 commit that should fix the test. |
targos
added
the
commit-queue-rebase
panva
approved these changes
May 8, 2026
panva
added
author ready
MattiasBuelens
approved these changes
May 8, 2026
joyeecheung
approved these changes
May 8, 2026
jasnell
approved these changes
May 8, 2026
Collaborator
Author
github-actions
Bot
removed
the
request-ci
Collaborator
Author
Collaborator
Author
Collaborator
Author
Collaborator
Author
joyeecheung
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/63136 ✔ Done loading data for nodejs/node/pull/63136 ----------------------------------- PR info ------------------------------------ Title test: update WPT for wasm/jsapi to 288c467d35 (#63136) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/update-wasm/jsapi-wpt -> nodejs:main Labels v8 engine, test, author ready, needs-ci, commit-queue-rebase Commits 3 - deps: V8: cherry-pick 435a2cdf664c - test: update WPT for wasm/jsapi to 288c467d35 - fixup! test: update WPT for wasm/jsapi to 288c467d35 Committers 1 - Michaël Zasso <targos@protonmail.com> PR-URL: https://github.com/nodejs/node/pull/63136 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63136 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 05 May 2026 21:47:41 GMT ✔ Approvals: 4 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/63136#pullrequestreview-4252577717 ✔ - Mattias Buelens (@MattiasBuelens): https://github.com/nodejs/node/pull/63136#pullrequestreview-4252624295 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/63136#pullrequestreview-4252809319 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63136#pullrequestreview-4252816132 ✘ GitHub CI failed with status: FAILURE ℹ Last Full PR CI on 2026-05-08T14:16:57Z: https://ci.nodejs.org/job/node-test-pull-request/73265/ - Querying data for job/node-test-pull-request/73265/ ✔ Build data downloaded - Querying failures of job/node-test-commit/87695/ ✔ Data downloaded ✘ 20 failure(s) on the last Jenkins CI run -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/25584142581 |
Collaborator
Author
Collaborator
Author
Collaborator
Author
lpinca
approved these changes
May 9, 2026
Collaborator
Author
Member
|
I'm going to stop rerunning Windows for now. It fails almost all the time: https://ci.nodejs.org/job/node-test-commit-windows-fanned/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of the WPT for wasm/jsapi to web-platform-tests/wpt@288c467.