Skip to content

Bump NcVue to v8.6.2#2157

Closed
ShGKme wants to merge 3 commits into
masterfrom
deps/nextcloud/vue-8.6.2
Closed

Bump NcVue to v8.6.2#2157
ShGKme wants to merge 3 commits into
masterfrom
deps/nextcloud/vue-8.6.2

Conversation

@ShGKme

@ShGKme ShGKme commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Feb 8, 2024
@ShGKme ShGKme self-assigned this Feb 8, 2024
@ShGKme

ShGKme commented Feb 8, 2024

Copy link
Copy Markdown
Contributor Author

@skjnldsv Cypress tests are always #ff0000 on viewer, and for me it is always non-obious if it is related. Can we merge both PRs and fix Cypress later if they are related?

Same for the backport.

@skjnldsv

skjnldsv commented Feb 8, 2024

Copy link
Copy Markdown
Member

Only sharing/download-share-disabled.cy.ts is failing on master it seems, haven't took the time to fix them for now.

@Pytal Pytal mentioned this pull request Feb 8, 2024
@ShGKme

ShGKme commented Feb 9, 2024

Copy link
Copy Markdown
Contributor Author

/compile amend

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@ShGKme

ShGKme commented Mar 1, 2024

Copy link
Copy Markdown
Contributor Author

Done in #2181

@ShGKme ShGKme closed this Mar 1, 2024
@skjnldsv skjnldsv deleted the deps/nextcloud/vue-8.6.2 branch September 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants