Skip to content

[stable33] chore: Add explicit dependency for terser-webpack-plugin - #1504

Merged
danxuliu merged 2 commits into
stable33from
backport/1502/stable33
Aug 8, 2026
Merged

[stable33] chore: Add explicit dependency for terser-webpack-plugin#1504
danxuliu merged 2 commits into
stable33from
backport/1502/stable33

Conversation

@backportbot

@backportbot backportbot Bot commented Aug 8, 2026

Copy link
Copy Markdown

Backport of #1502

@backportbot
backportbot Bot requested review from ShGKme and danxuliu August 8, 2026 21:04
@backportbot backportbot Bot added this to the Nextcloud 33.0.8 milestone Aug 8, 2026
terser-webpack-plugin was already an implicit dependency, but now it is
made explicit to ensure that the build process will not break if the
implicit dependency is removed.

This could happen with an update to webpack >= 5.108.0, as it replaced
terser-webpack-plugin with minimizer-webpack-plugin. However, note that
even if terser-webpack-plugin was also replaced with
minimizer-webpack-plugin in webpack.config.js in the PDF viewer the
build could still break, as the latest webpack-vue-config version
(7.0.3) also uses both webpack >= 5.108.0 and terser-webpack-plugin
without depending on the later.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu
danxuliu force-pushed the backport/1502/stable33 branch from 5b5d7a2 to bb974e0 Compare August 8, 2026 21:18
@danxuliu

danxuliu commented Aug 8, 2026

Copy link
Copy Markdown
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@danxuliu
danxuliu marked this pull request as ready for review August 8, 2026 21:35
@danxuliu
danxuliu merged commit d5416b5 into stable33 Aug 8, 2026
36 checks passed
@danxuliu
danxuliu deleted the backport/1502/stable33 branch August 8, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants