chore: Add explicit dependency for terser-webpack-plugin

[danxuliu]

terser-webpack-plugin was already an implicit dependency, but now it is made explicit to ensure that the build process will not break if the implicit dependency is removed.

This could happen with an update to webpack >= 5.108.0, as it replaced terser-webpack-plugin with minimizer-webpack-plugin. However, note that even if terser-webpack-plugin was also replaced with minimizer-webpack-plugin in webpack.config.js in the PDF viewer the build could still break, as the latest webpack-vue-config version (7.0.3) also uses both webpack >= 5.108.0 and terser-webpack-plugin without depending on the later.

[danxuliu]

/backport to stable34 please

[danxuliu]

/backport to stable33 please

[danxuliu]

/backport to stable32 please

[ShGKme]

This dependency isn't used directly by the files_pdfviewer itself. It is used by its dependency - the @nextcloud/webpack-vue-config.

• If @nextcloud/webpack-vue-config updates, for example, to use minimizer-webpack-plugin - it will break again.
• If somebody checks the list of dependencies, it can be found that this one is never imported by the app and accidentally removed

The proper fix should be on the library side:

• build: no extraneous terser-webpack-plugin nextcloud-libraries/webpack-vue-config#800

[danxuliu]

This dependency isn't used directly by the files_pdfviewer itself. It is used by its dependency - the @nextcloud/webpack-vue-config.

It is... or what am I missing? 🤔

files_pdfviewer/webpack.config.js

Line 8 in c0f94ce

const TerserPlugin = require('terser-webpack-plugin')

[ShGKme]

Ahh, I see, correct

[danxuliu]

/compile