[stable33] fix: Add explicit dependency for vue-loader@legacy - #1497
Merged
Conversation
Current vue-loader@legacy installed as transitive has a vulnerable dependency, and there is no fix for the installed major version. When "npm audit fix" is run it tries to update vue-loader to another major, because no version is explicitly specified in the project. Fortunately, the postinstall script of webpack-vue-config verifies that the right version of vue-loader is installed and aborts the process (with a nice warning) if it is not. However, due to all of the above, when "npm audit fix" is run by the workflow the command fails and no fix is applied. To solve that now an explicit dependency is added again for vue-loader@legacy. Note that the explicit dependency was removed in the past due to being automatically handled when the dependencies are installed, but it is necessary when nothing is installed and the dependency has a vulnerability. Thanks ShGKme for the explanation! Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
backport/1496/stable33
branch
from
August 7, 2026 04:29
fb19703 to
9482d71
Compare
danxuliu
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #1496