fix: Add explicit dependency for vue-loader@legacy - #1496
Merged
Conversation
Current vue-loader@legacy installed as transitive has a vulnerable dependency, and there is no fix for the installed major version. When "npm audit fix" is run it tries to update vue-loader to another major, because no version is explicitly specified in the project. Fortunately, the postinstall script of webpack-vue-config verifies that the right version of vue-loader is installed and aborts the process (with a nice warning) if it is not. However, due to all of the above, when "npm audit fix" is run by the workflow the command fails and no fix is applied. To solve that now an explicit dependency is added again for vue-loader@legacy. Note that the explicit dependency was removed in the past due to being automatically handled when the dependencies are installed, but it is necessary when nothing is installed and the dependency has a vulnerability. Thanks ShGKme for the explanation! Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Member
Author
|
/backport to stable34 please |
Member
Author
|
/backport to stable33 please |
Member
Author
|
/backport to stable32 please |
ShGKme
approved these changes
Aug 6, 2026
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/1496/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 48073f89
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1496/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Aug 7, 2026
Member
Author
I did not realize that the backport to stable32 was not needed, as vue-loader is already an explicit dependency in that branch and therefore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
vue-loader@legacyinstalled as transitive has a vulnerable dependency, and there is no fix for the installed major version. Whennpm audit fixis run it tries to updatevue-loaderto another major, because no version is explicitly specified in the project. Fortunately, the postinstall script ofwebpack-vue-configverifies that the right version ofvue-loaderis installed and aborts the process (with a nice warning) if it is not.However, due to all of the above, when
npm audit fixis run by the workflow the command fails and no fix is applied (although the error is only visible when debug logs are enabled). To solve that now an explicit dependency is added again forvue-loader@legacy.Note that the explicit dependency was removed in the past due to being automatically handled when the dependencies are installed, but it is necessary when nothing is installed and the dependency has a vulnerability.
Thanks @ShGKme for the explanation!