TPT-3454: Refactor wait functions to use context for timeouts and polling

[zliang-akamai]

📝 Description

Require timeout to be passed in context for the WaitFor... functions and intentionally remove timeoutSeconds from functions' parameters.

✔️ How to Test

make test-int

[Copilot]

Pull request overview

Refactors the SDK's WaitFor* family in waitfor.go so timeouts are driven entirely by the caller's context.Context instead of an explicit timeoutSeconds int parameter, and consolidates per-function poll loops into a generic poll[T] helper. Integration and unit tests are updated to construct contexts via a new waitContext(t, timeout) helper.

Changes:

• Removes timeoutSeconds from many exported WaitFor* functions and from LKEClusterPollOptions, replacing the inline ticker/select loops with a shared generic poll helper and newTicker(client).
• Adds a waitContext helper (in integration_suite_test.go) plus a new unit test file test/unit/waitfor_test.go covering deadline, success, nil-LinodeID, and event-poller paths.
• Threads ctx context.Context through setupPostgresDatabase, setupMySQLDatabase, setupInstanceBackup, setupVolumeAttachedToLinode, and waitForDatabaseUpdated, and updates all callers to pass the new context-derived timeouts.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
waitfor.go	Drops timeoutSeconds params, introduces generic poll/newTicker, refactors most WaitFor* funcs, adds previousEvents init in NewEventPoller.
test/integration/integration_suite_test.go	Adds waitContext(t, timeout) helper based on t.Context().
test/unit/waitfor_test.go	New unit tests exercising context-driven wait behavior with httpmock.
test/integration/iam_io_ready_test.go	Threads ctx through setupVolumeAttachedToLinode; uses fresh ctx in cleanup.
test/integration/instance_snapshots_test.go	Adds ctx param to setupInstanceBackup, updates wait calls.
test/integration/instances_test.go	Adds per-test waitContext and updates many WaitFor* call sites.
test/integration/instance_config_test.go	Adds ctx for WaitForVolumeStatus calls.
test/integration/images_test.go	Adds ctx for WaitForImageStatus calls.
test/integration/image_sharegroups_test.go	Adds ctx for WaitForImageStatus.
test/integration/lke_clusters_test.go	Drops TimeoutSeconds, passes ctx to WaitForLKEClusterReady/WaitForLKEClusterStatus.
test/integration/lke_node_pools_test.go	Same ctx-based update for LKE waits.
test/integration/monitor_alert_definitions_test.go	Updates WaitForAlertDefinitionStatus call.
test/integration/monitor_api_service_test.go	Threads ctx through setup.
test/integration/monitor_services_token_creation_test.go	Passes ctx into setupPostgresDatabase.
test/integration/mysql_test.go / mysql_db_config_test.go	Adds ctx param to setupMySQLDatabase, updates DB waits.
test/integration/postgres_test.go / postgres_db_config_test.go	Adds ctx param to setupPostgresDatabase, updates DB waits.
test/integration/databases_test.go	Adds ctx param to waitForDatabaseUpdated.
test/integration/vlans_test.go	Adds ctx for WaitForInstanceStatus calls.
test/integration/volumes_test.go	Adds ctx for WaitForVolumeStatus/WaitForVolumeLinodeID calls.
test/integration/waitfor_test.go	Adds ctx for WaitForFinished/WaitForResourceFree.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

[ezilber-akamai]

Changes look good and tests pass locally!

[lgarber-akamai]

Looks great and works well in my local testing, nice work!