test: make ProcessInstanceAdminServiceImplTest deterministic - #2487
Open
Jack-LuoHongyi wants to merge 1 commit into
Open
test: make ProcessInstanceAdminServiceImplTest deterministic#2487Jack-LuoHongyi wants to merge 1 commit into
Jack-LuoHongyi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jbpm-services/jbpm-kie-servicesRoot Cause
The shared
@Beforesetup serialises a deployment descriptor whose content order depends on iteration over unordered collections. When the runtime perturbs iteration order, the generated XML violates the schema, so the affected tests never exercise their assertions.Fix
Provide a deterministic
kie-deployment-descriptor.xmlstring in the test fixture. The file mirrors the descriptor produced by the builder, so all listeners and persistence settings remain intact. This change eliminates order variation without easing assertions, and coverage stays unchanged because every test still deploys the same assets and executes the same runtime paths.Validation
edu.illinois:nondex-maven-plugin:2.1.7tooling.Risk
Low. The change only stabilises fixture data while preserving original validation logic.