test: make org.jbpm.kie.services.impl.admin.ProcessInstanceAdminServiceImplTest.testGetNodes deterministic - #2474
Closed
Jack-LuoHongyi wants to merge 1 commit into
Conversation
…ceImplTest deterministic
Author
|
a more complete solution in #2487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jbpm-services/jbpm-kie-servicesorg.jbpm.kie.services.impl.admin.ProcessInstanceAdminServiceImplTest#testGetNodesRoot Cause
JAXB serialization of the deployment descriptor is order-sensitive with respect to the schema. When collection iteration order varies, the marshaller can emit elements (e.g.,
audit-persistence-unit) before expected groups, leading to schema validation errors during descriptor generation. This manifests as intermittent test failures when the iteration order differs across runs.Fix
Provide a pre-rendered
kie-deployment-descriptor.xmlin the test fixture (StableDescriptorXml) and add it viaextraResourceswhen building the test KJAR. The XML mirrors the descriptor produced byAbstractKieServicesTest#createDeploymentDescriptor()for this test (including the event listener), ensuring stable, schema-compliant element order without changing any runtime behavior or assertions.Validation
mvn -pl jbpm-services/jbpm-kie-services -Dtest=org.jbpm.kie.services.impl.admin.ProcessInstanceAdminServiceImplTest#testGetNodes testpasses consistentlyRisk
Low. Test-only resource injection; no production classes modified. The descriptor content is equivalent, just rendered with a stable element order.