feat: add config file with Settings class for database credentials by adityashirsatrao007 · Pull Request #113 · josdem/py-vetlog-buddy

adityashirsatrao007 · 2025-12-10T17:56:26Z

Summary

Adds a config module with a Settings class to read database credentials from environment variables.

Changes

Added \src/vetlog_buddy/config.py\ with \Settings\ class using \pydantic-settings\
Settings reads: \db_host, \db_name, \db_user, \db_password\ from env
Added \database_url\ property that returns MySQL connection string format
Added unit tests in \ ests/unit/test_config.py\

Testing

\
python -m pytest tests/unit/test_config.py -v
\\

Closes #112

Implements #112 - Add config.py with Settings class using pydantic-settings - Add database_url property for MySQL connection string - Add unit tests for Settings class

Copilot

Pull request overview

This PR adds a new config.py module with a Settings class for managing database credentials via environment variables using pydantic-settings. However, this duplicates existing functionality already present in src/vetlog_buddy/shared/config.py, which has a more complete Settings class that includes the same database fields plus additional configuration (e.g., factor field) and proper .env file loading via a Config inner class.

Key Changes:

Added src/vetlog_buddy/config.py with a Settings class reading db_host, db_name, db_user, db_password from environment variables
Added database_url property that constructs MySQL connection strings
Added unit tests in tests/unit/test_config.py using unittest framework

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
src/vetlog_buddy/config.py	Introduces Settings class for database configuration, duplicating functionality from shared/config.py; lacks URL encoding for credentials and .env file loading configuration
tests/unit/test_config.py	Adds unit tests for Settings class using unittest (inconsistent with project's pytest convention); missing test coverage for error cases and special character handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

josdem

Hi @adityashirsatrao007 ; I appreciate that you sent a PR, however you have several comments from Copilot, please address those, so we can merge your PR.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

… fixtures (#113)

josdem

Only one more change to go and then we can merge. I appreciate your contriburion @adityashirsatrao007

josdem · 2025-12-10T22:01:22Z

@all-contributors please add @adityashirsatrao007 for code

allcontributors · 2025-12-10T22:01:32Z

@josdem

I've put up a pull request to add @adityashirsatrao007! 🎉

adityashirsatrao007 · 2025-12-11T03:19:46Z

@copilot open a new pull request to apply changes based on the comments in this thread

adityashirsatrao007 · 2025-12-11T03:20:17Z

Quote reply

Done with the changes,you can check.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

adityashirsatrao007 · 2025-12-11T03:28:48Z

@copilot open a new pull request to apply changes based on the comments in this thread

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adityashirsatrao007 · 2025-12-11T03:30:19Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adityashirsatrao007 · 2025-12-11T03:48:58Z

@copilot open a new pull request to apply changes based on the comments in this thread

jgafnea · 2025-12-11T15:51:18Z

Smart use of cache.

jgafnea

Approved! Cached getter is a smart update for testability and cleaner DI.

blu3-bird

Looks good to me.

josdem

It looks good to me, thanks for doing suggested changes @adityashirsatrao007 I appreciate it.

feat: add config file with Settings class for database credentials

ef7fabb

Implements #112 - Add config.py with Settings class using pydantic-settings - Add database_url property for MySQL connection string - Add unit tests for Settings class

Copilot AI review requested due to automatic review settings December 10, 2025 17:56

Copilot started reviewing on behalf of adityashirsatrao007 December 10, 2025 17:56 View session

Copilot AI reviewed Dec 10, 2025

View reviewed changes

josdem requested changes Dec 10, 2025

View reviewed changes

josdem requested review from blu3-bird, jgafnea and kaminuma December 10, 2025 18:12

adityashirsatrao007 and others added 3 commits December 10, 2025 23:44

Update tests/unit/test_config.py

5dfa244

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/vetlog_buddy/config.py

e8cf16c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

refactor(config): remove global Settings instantiation and use pytest…

1ddba9d

… fixtures (#113)

josdem requested changes Dec 10, 2025

View reviewed changes

Comment thread tests/unit/test_config.py Outdated

allcontributors Bot mentioned this pull request Dec 10, 2025

docs: add adityashirsatrao007 as a contributor for code #114

Merged

adityashirsatrao007 added 2 commits December 11, 2025 08:42

fix(test): disable default .env loading in test_missing_vars

791eb44

refactor(test): use pytest fixture for negative test case

db7613f

adityashirsatrao007 requested review from Copilot and josdem December 11, 2025 03:20

Copilot started reviewing on behalf of adityashirsatrao007 December 11, 2025 03:20 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

adityashirsatrao007 and others added 4 commits December 11, 2025 08:58

Update src/vetlog_buddy/config.py

c92a2a5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/vetlog_buddy/config.py

e33986e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/unit/test_config.py

2f04a7a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/unit/test_config.py

1883f84

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adityashirsatrao007 requested a review from Copilot December 11, 2025 03:30

Copilot started reviewing on behalf of adityashirsatrao007 December 11, 2025 03:31 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Comment thread src/vetlog_buddy/shared/config.py

Comment thread src/vetlog_buddy/shared/config.py

Comment thread tests/unit/test_config.py

Comment thread tests/unit/test_config.py

Comment thread src/vetlog_buddy/config.py Outdated

adityashirsatrao007 and others added 3 commits December 11, 2025 09:14

Update src/vetlog_buddy/config.py

d9f021e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/vetlog_buddy/shared/config.py

695dcc9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/vetlog_buddy/shared/config.py

48a2d3e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jgafnea reviewed Dec 11, 2025

View reviewed changes

jgafnea approved these changes Dec 11, 2025

View reviewed changes

blu3-bird approved these changes Dec 11, 2025

View reviewed changes

josdem approved these changes Dec 11, 2025

View reviewed changes

josdem merged commit ce3b2ac into josdem:main Dec 11, 2025

Conversation

adityashirsatrao007 commented Dec 10, 2025

Summary

Changes

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

josdem left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

josdem left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

josdem commented Dec 10, 2025

Uh oh!

allcontributors Bot commented Dec 10, 2025

Uh oh!

adityashirsatrao007 commented Dec 11, 2025

Uh oh!

adityashirsatrao007 commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adityashirsatrao007 commented Dec 11, 2025

Uh oh!

adityashirsatrao007 commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adityashirsatrao007 commented Dec 11, 2025

Uh oh!

jgafnea Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgafnea left a comment

Choose a reason for hiding this comment

Uh oh!

blu3-bird left a comment

Choose a reason for hiding this comment

Uh oh!

josdem left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

josdem left a comment •

edited

Loading

jgafnea Dec 11, 2025 •

edited

Loading