Merge pull request #113 from adityashirsatrao007/feature/112

feat: add config file with Settings class for database credentials

Author: josdem

src/vetlog_buddy/config.py

@@ -0,0 +1 @@
+# (File deleted)

src/vetlog_buddy/shared/config.py

@@ -28,4 +28,17 @@ class Config:
         env_file_encoding = "utf-8"
 
 
-settings = Settings()
+from functools import lru_cache
+
+
+@lru_cache
+def get_settings():
+    """
+    Returns a cached instance of the Settings class.
+    """
+    """
+    Returns a cached instance of Settings using lru_cache.
+    This ensures that environment variables are read only once and
+    repeated calls return the same Settings object.
+    """
+    return Settings()

src/vetlog_buddy/shared/database.py

@@ -14,7 +14,9 @@
 from urllib.parse import quote_plus
 from sqlmodel import Session, create_engine
 
-from vetlog_buddy.shared.config import settings
+from vetlog_buddy.shared.config import get_settings
+
+settings = get_settings()
 
 database_url: str = f"mysql+mysqlconnector://{quote_plus(settings.db_user)}:{quote_plus(settings.db_password)}@{settings.db_host}/{settings.db_name}"
 engine = create_engine(database_url, echo=False, pool_pre_ping=True)

tests/unit/test_config.py

@@ -0,0 +1,40 @@
+import os
+from unittest.mock import patch
+
+import pytest
+from pydantic import ValidationError
+
+from vetlog_buddy.shared.config import Settings
+
+
+@pytest.fixture
+def mock_env_vars():
+    with patch.dict(
+        os.environ,
+        {
+            "DB_HOST": "localhost",
+            "DB_NAME": "vetlog",
+            "DB_USER": "vetlogUser",
+            "DB_PASSWORD": "vetlogDB",
+        },
+    ):
+        yield
+
+
+def test_settings_loads_from_env(mock_env_vars):
+    settings = Settings()
+    assert settings.db_host == "localhost"
+    assert settings.db_name == "vetlog"
+    assert settings.db_user == "vetlogUser"
+    assert settings.db_password == "vetlogDB"
+
+
+@pytest.fixture
+def clean_env():
+    with patch.dict(os.environ, {}, clear=True):
+        yield
+
+
+def test_settings_missing_required_vars(clean_env):
+    with pytest.raises(ValidationError):
+        Settings()