Update pki_secret_backend_crl_config to be more resilent to unknown response fields - #2429
Merged
Merged
Conversation
stevendpclark
commented
Mar 12, 2025
| } | ||
| } | ||
|
|
||
| if err := util.SetResourceData(d, config.Data); err != nil { |
Contributor
Author
There was a problem hiding this comment.
This is the main fix here, passing in config.Data into util.SetResourceData was causing issues when the Data map contained an unknown field
sgmiller
approved these changes
Mar 12, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not pass in the PKI CRL configuration response map directly into
util.SetResourceDataas this will fail if an unknown field is returned from Vault that isn't listed in the resource's schema. We encountered this within the Vault 1.19 release where the resource broke whenmax_crl_entrieswas added.Also this includes a slight refactoring to update the methods to the non-deprecated values along with removing duplication by adding a common method that builds up the list of fields based on Vault version.
Checklist
Output from acceptance testing:
Community Note